From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] dumpcap: remove bogus rte_free()
Date: Thu, 20 Oct 2022 15:18:40 -0700 [thread overview]
Message-ID: <20221020221840.305941-1-stephen@networkplumber.org> (raw)
At end of program there is call to rte_free() which is passing
a bogus value. There is no "bpf_filter" defined in this application;
it ends up being a text address inside pcap library.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index e0a3477d912f..e49558c2534a 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -849,7 +849,7 @@ int main(int argc, char **argv)
pcap_dump_close(out.dumper);
cleanup_pdump_resources();
- rte_free(bpf_filter);
+
rte_ring_free(r);
rte_mempool_free(mp);
--
2.35.1
next reply other threads:[~2022-10-20 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 22:18 Stephen Hemminger [this message]
2022-10-21 13:06 ` [PATCH] dumpcap: remove bogus rte_free() David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020221840.305941-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).