From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 10/15] mempool: rename populate functions
	to IOVA
Date: Mon, 06 Nov 2017 16:58:13 +0100
Message-ID: <2022205.xxQWC8C0TJ@xps>
References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com>
 <20171106014141.13266-11-thomas@monjalon.net>
 <20171106154930.f4ax36mllm45ion4@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 658D51B2EC
 for <dev@dpdk.org>; Mon,  6 Nov 2017 16:58:15 +0100 (CET)
In-Reply-To: <20171106154930.f4ax36mllm45ion4@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/11/2017 16:49, Olivier MATZ:
> On Mon, Nov 06, 2017 at 02:41:36AM +0100, Thomas Monjalon wrote:
> > The functions rte_mempool_populate_phys() and
> > rte_mempool_populate_phys_tab() are renamed to
> > rte_mempool_populate_iova() and rte_mempool_populate_iova_tab().
> > The deprecated functions are kept as aliases to avoid breaking the API.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> I agree with the changes of that patch too.
> However, after the patches, few references to phys address still
> remain in rte_mempool.h. Some examples below:
> 
> /** Mempool over one chunk of physically continuous memory */
> #define MEMPOOL_PG_NUM_DEFAULT  1
> ...
>  * The memory chunks where objects are stored. Each chunk is virtually
>  * and physically contiguous.
> ...
> #define MEMPOOL_F_NO_PHYS_CONTIG 0x0020 /**< Don't need physically contiguous objs. */
> /**
>  * This capability flag is advertised by a mempool handler, if the whole
>  * memory area containing the objects must be physically contiguous.
>  * Note: This flag should not be passed by application.
>  */
> #define MEMPOOL_F_CAPA_PHYS_CONTIG 0x0040
> ...
>  * - Mempool driver must also set MEMPOOL_F_CAPA_PHYS_CONTIG flag along with
>  *   MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS.
> ...
>  *   - Otherwise, rte_mempool_populate_phys fails thus pool create fails.
> ...
>  *   - MEMPOOL_F_NO_PHYS_CONTIG: If set, allocated objects won't
>  *     necessarily be contiguous in physical memory.
> ...
> ...
> 
> I think we should also change them to IO.

Yes I did not change them because I was not sure how to word it.
Feel free to send a patch for the flags and few other doxygen comments.
Thanks