From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] cmdline: check return value at
	initialization
Date: Thu, 19 May 2016 14:26:02 +0200
Message-ID: <2023616.jWtzSNvIF8@xps13>
References: <1463411889-22245-1-git-send-email-marcinx.kerlin@intel.com>
 <1463474217-30875-1-git-send-email-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Olivier Matz <olivier.matz@6wind.com>, marcinx.kerlin@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 0F5738E69
 for <dev@dpdk.org>; Thu, 19 May 2016 14:26:14 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id n129so228144367wmn.1
 for <dev@dpdk.org>; Thu, 19 May 2016 05:26:14 -0700 (PDT)
In-Reply-To: <1463474217-30875-1-git-send-email-olivier.matz@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-17 10:36, Olivier Matz:
> From: Marcin Kerlin <marcinx.kerlin@intel.com>
> 
> The value returned by rdline_init() was not checked in cmdline_new().
> On error, free the allocated memory and return NULL.
> 
> This condition should not happen today, but it's safer to do the check
> in case rdline_init() is updated.
> 
> Fixes: af75078fece3 ("first public release")
> Coverity ID 13204
> 
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> 
> Hi Marcin,
> 
> I updated the commit log and title to be clearer.

Applied, thanks