From: Stephen Hemminger <stephen@networkplumber.org>
To: <shaibran@amazon.com>
Cc: <ferruh.yigit@amd.com>, <dev@dpdk.org>,
Amit Bernstein <amitbern@amazon.com>
Subject: Re: [PATCH 1/1] net/ena: add histogram support
Date: Tue, 29 Oct 2024 09:22:34 -0700 [thread overview]
Message-ID: <20241029092234.0935fd9a@hermes.local> (raw)
In-Reply-To: <20241029080215.5069-2-shaibran@amazon.com>
On Tue, 29 Oct 2024 10:02:15 +0200
<shaibran@amazon.com> wrote:
> From: Shai Brandes <shaibran@amazon.com>
>
> The framework computes the differences between specified
> start and end points in the code, providing insights into
> performance by outputting a histogram of the time intervals.
> The histogram can be used to track metrics like packet
> processing latency in the network driver.
> This framework requires enablement via a compilation
> flag and is excluded in release builds by default.
>
> Signed-off-by: Amit Bernstein <amitbern@amazon.com>
> Signed-off-by: Shai Brandes <shaibran@amazon.com>
Could this be generic for all PMD's and built off of existing DPDK trace mechanism?
Yes, histogram is useful.
But IMHO DPDK should discourage PMD specific features.
next prev parent reply other threads:[~2024-10-29 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 8:02 [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0 shaibran
2024-10-29 8:02 ` [PATCH 1/1] net/ena: add histogram support shaibran
2024-10-29 16:22 ` Stephen Hemminger [this message]
2024-10-31 12:46 ` Brandes, Shai
2024-10-29 8:54 ` [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0 Morten Brørup
2024-10-31 12:45 ` Brandes, Shai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029092234.0935fd9a@hermes.local \
--to=stephen@networkplumber.org \
--cc=amitbern@amazon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=shaibran@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).