From: Stephen Hemminger <stephen@networkplumber.org>
To: Lukas Sismis <sismis@cesnet.cz>
Cc: chas3@att.com, dev@dpdk.org
Subject: Re: [PATCH] net/bonding: make bonding functions stable
Date: Tue, 29 Oct 2024 10:36:09 -0700 [thread overview]
Message-ID: <20241029103609.2d668596@hermes.local> (raw)
In-Reply-To: <20241029154113.310040-1-sismis@cesnet.cz>
On Tue, 29 Oct 2024 16:41:13 +0100
Lukas Sismis <sismis@cesnet.cz> wrote:
> diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
> index a309469b1f..68b892d1e6 100644
> --- a/drivers/net/bonding/version.map
> +++ b/drivers/net/bonding/version.map
> @@ -26,13 +26,3 @@ DPDK_25 {
>
> local: *;
> };
> -
> -EXPERIMENTAL {
> - # added in 23.11
> - global:
> - rte_eth_bond_8023ad_member_info;
> - rte_eth_bond_active_members_get;
> - rte_eth_bond_member_add;
> - rte_eth_bond_member_remove;
> - rte_eth_bond_members_get;
> -};
> --
The build of this patch fails.
Need to add these functions into the DPDK_25 section.
The list there needs to stay alphabetical.
Something like:
diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
index a309469b1f..eb37dadf76 100644
--- a/drivers/net/bonding/version.map
+++ b/drivers/net/bonding/version.map
@@ -11,12 +11,17 @@ DPDK_25 {
rte_eth_bond_8023ad_ext_distrib;
rte_eth_bond_8023ad_ext_distrib_get;
rte_eth_bond_8023ad_ext_slowtx;
+ rte_eth_bond_8023ad_member_info;
rte_eth_bond_8023ad_setup;
+ rte_eth_bond_active_members_get;
rte_eth_bond_create;
rte_eth_bond_free;
rte_eth_bond_link_monitoring_set;
rte_eth_bond_mac_address_reset;
rte_eth_bond_mac_address_set;
+ rte_eth_bond_member_add;
+ rte_eth_bond_member_remove;
+ rte_eth_bond_members_get;
rte_eth_bond_mode_get;
rte_eth_bond_mode_set;
rte_eth_bond_primary_get;
@@ -26,13 +31,3 @@ DPDK_25 {
local: *;
};
-
-EXPERIMENTAL {
- # added in 23.11
- global:
- rte_eth_bond_8023ad_member_info;
- rte_eth_bond_active_members_get;
- rte_eth_bond_member_add;
- rte_eth_bond_member_remove;
- rte_eth_bond_members_get;
-};
next prev parent reply other threads:[~2024-10-29 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 15:41 [PATCH] net/bonding: make bonding functions stable Lukas Sismis
2024-10-29 16:10 ` Stephen Hemminger
2024-10-29 17:36 ` Stephen Hemminger [this message]
2024-10-29 20:23 ` Lukáš Šišmiš
-- strict thread matches above, loose matches on Subject: below --
2024-10-29 14:42 Lukas Sismis
2024-10-29 16:10 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029103609.2d668596@hermes.local \
--to=stephen@networkplumber.org \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=sismis@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).