From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id A025DE7717D for ; Fri, 13 Dec 2024 11:31:30 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0B75409FA; Fri, 13 Dec 2024 12:31:29 +0100 (CET) Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210]) by mails.dpdk.org (Postfix) with ESMTP id DE97A40A67 for ; Fri, 13 Dec 2024 12:31:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=eurecom.fr; i=@eurecom.fr; q=dns/txt; s=default; t=1734089488; x=1765625488; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=25Mk1wADhmJ9aRaP8Bn5SuI4BKmOZDOD4d9WqZFtaB8=; b=TovrEJRDAlMDMos9FfpRnTg+VMVYIDHeuvdmttL90Sr00o3Vn5eKW6Rr qccMgn8DO6VIca4sBM3i+PtfhHRd8hwRsAbZcGsuZ2ONHwRXS5PkuYIiF a19iE5ArUZV/9EL1zMR0CVFYy9kyI7Ln8LWydMCdnmJqp/3UUBwDJNujT c=; X-CSE-ConnectionGUID: J9PMRlZ4SYO+/qKnc0bpDQ== X-CSE-MsgGUID: jGHUJHaNSX2Wrxo7p0rYHA== X-IronPort-AV: E=Sophos;i="6.12,231,1728943200"; d="scan'208";a="28171799" Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236]) by drago1i.eurecom.fr with ESMTP; 13 Dec 2024 12:31:28 +0100 Received: from localhost.localdomain (88-183-119-157.subs.proxad.net [88.183.119.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtps.eurecom.fr (Postfix) with ESMTPSA id 725782B31; Fri, 13 Dec 2024 12:31:28 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: Thomas Monjalon , David Marchand , Cristian Dumitrescu , Ariel Otilibili Subject: [PATCH 1/1] app/test: remove useless calls to rte_bitmap_free Date: Fri, 13 Dec 2024 12:30:00 +0100 Message-ID: <20241213113059.59320-2-otilibil@eurecom.fr> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241213113059.59320-1-otilibil@eurecom.fr> References: <20241213113059.59320-1-otilibil@eurecom.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org * rte_bitmap_free is only useful for its return value * and its return value is not used. ``` $ < lib/eal/include/rte_bitmap.h sed -ne '/bitmap_free/,/^}/p' rte_bitmap_free(struct rte_bitmap *bmp) { /* Check input arguments */ if (bmp == NULL) { return -1; } return 0; } ``` Reported-by: Coverity, IDs 357712 & 357737 Signed-off-by: Ariel Otilibili --- app/test/test_bitmap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c index bab11812c7..a21210a215 100644 --- a/app/test/test_bitmap.c +++ b/app/test/test_bitmap.c @@ -208,7 +208,6 @@ test_bitmap_all_clear(void) if (test_bitmap_scan_operations(bmp) < 0) return TEST_FAILED; - rte_bitmap_free(bmp); rte_free(mem); return TEST_SUCCESS; @@ -254,7 +253,6 @@ test_bitmap_all_set(void) return TEST_FAILED; } - rte_bitmap_free(bmp); rte_free(mem); return TEST_SUCCESS; -- 2.47.1