From: Ariel Otilibili <otilibil@eurecom.fr>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Ariel Otilibili <otilibil@eurecom.fr>
Subject: [v2 1/1] app/test: remove useless calls to rte_bitmap_free
Date: Fri, 13 Dec 2024 12:38:42 +0100 [thread overview]
Message-ID: <20241213114452.59377-2-otilibil@eurecom.fr> (raw)
In-Reply-To: <20241213114452.59377-1-otilibil@eurecom.fr>
* rte_bitmap_free is only useful for its return value
* and its return value is not used.
```
$ < lib/eal/include/rte_bitmap.h sed -ne '/bitmap_free/,/^}/p'
rte_bitmap_free(struct rte_bitmap *bmp)
{
/* Check input arguments */
if (bmp == NULL) {
return -1;
}
return 0;
}
```
Coverity issue: 357712
Coverity issue: 357737
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
app/test/test_bitmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c
index bab11812c7..a21210a215 100644
--- a/app/test/test_bitmap.c
+++ b/app/test/test_bitmap.c
@@ -208,7 +208,6 @@ test_bitmap_all_clear(void)
if (test_bitmap_scan_operations(bmp) < 0)
return TEST_FAILED;
- rte_bitmap_free(bmp);
rte_free(mem);
return TEST_SUCCESS;
@@ -254,7 +253,6 @@ test_bitmap_all_set(void)
return TEST_FAILED;
}
- rte_bitmap_free(bmp);
rte_free(mem);
return TEST_SUCCESS;
--
2.47.1
prev parent reply other threads:[~2024-12-13 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 11:29 [PATCH 0/1] app/test: remove useless calls to rte_bitmap_free Ariel Otilibili
2024-12-13 11:30 ` [PATCH 1/1] " Ariel Otilibili
2024-12-13 16:59 ` Stephen Hemminger
2024-12-13 21:38 ` Ariel Otilibili-Anieli
2024-12-13 11:38 ` [v2 0/1] " Ariel Otilibili
2024-12-13 11:38 ` Ariel Otilibili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213114452.59377-2-otilibil@eurecom.fr \
--to=otilibil@eurecom.fr \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox