From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] testpmd: limit port mask bits to RTE_MAX_ETHPORTS Date: Wed, 17 Dec 2014 01:09:29 +0100 Message-ID: <2024529.1MsobXgOel@xps13> References: <20141216140926.GD13806@hmsreliant.think-freely.org> <1418740784-12155-1-git-send-email-bruce.richardson@intel.com> <20141216214343.GG13806@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Bruce Richardson Return-path: In-Reply-To: <20141216214343.GG13806-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-16 16:43, Neil Horman: > On Tue, Dec 16, 2014 at 02:39:44PM +0000, Bruce Richardson wrote: > > The port mask parsing in testpmd allowed up to 64 bits to be processed, > > even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only > > processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask. > > > > Signed-off-by: Bruce Richardson > > --- > > V2: changed to use RTE_MIN in comparison, instead of double "<". > > I was thinking of assigning a new temp variable to the return of RTE_MIN so as > to avoid the comparison within the for loop, but since both arguments are > constant, I'm sure the compiler will avoid multiple comparisons. > > Acked-by: Neil Horman Applied Thanks -- Thomas