From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 2/3] net/i40e: implement device reset on
	port
Date: Thu, 20 Apr 2017 23:20:13 +0200
Message-ID: <2024625.2sU8lOsUIU@xps>
References: <1491461483-39861-1-git-send-email-wei.zhao1@intel.com>
 <1491793349-46840-1-git-send-email-wei.zhao1@intel.com>
 <1491793349-46840-3-git-send-email-wei.zhao1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Wei Zhao <wei.zhao1@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A1A192904
 for <dev@dpdk.org>; Thu, 20 Apr 2017 23:20:14 +0200 (CEST)
In-Reply-To: <1491793349-46840-3-git-send-email-wei.zhao1@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/04/2017 05:02, Wei Zhao:
> +	memset(dev->data->dev_private, 0,
> +	       (uint64_t)&adapter->reset_flag - (uint64_t)adapter);

It does not compile for 32-bit.
Should it be replaced by offsetof()?

Does it mean that new fields should be added before reset_flag?
There is no comment about position importance of this field in the struct.
By the way, there is a field ptype_tbl appeared recently. Where should it
be positionned after rebase?