dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/ice: fix initialization with 8 ports
@ 2025-09-30 14:28 Bruce Richardson
  2025-10-09 13:28 ` Rybalchenko, Kirill
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2025-09-30 14:28 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

When initializing an 8-port device, the ACL configuration
failed with the adminq returning an ENOMEM status from the
sixth port onwards. Fix this issue by halving the depth, and
therefore the space required, when using a device with >4 PFs.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/intel/ice/ice_acl_filter.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/intel/ice/ice_acl_filter.c b/drivers/net/intel/ice/ice_acl_filter.c
index 83cb3e36f9..38e30a4f62 100644
--- a/drivers/net/intel/ice/ice_acl_filter.c
+++ b/drivers/net/intel/ice/ice_acl_filter.c
@@ -114,7 +114,10 @@ ice_acl_setup(struct ice_pf *pf)
 	else
 		params.width = ICE_AQC_ACL_KEY_WIDTH_BYTES * 3;
 
-	params.depth = ICE_AQC_ACL_TCAM_DEPTH;
+	if (pf_num > 4)
+		params.depth = ICE_AQC_ACL_TCAM_DEPTH / 2;
+	else
+		params.depth = ICE_AQC_ACL_TCAM_DEPTH;
 	params.entry_act_pairs = 1;
 	params.concurr = false;
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] net/ice: fix initialization with 8 ports
  2025-09-30 14:28 [PATCH] net/ice: fix initialization with 8 ports Bruce Richardson
@ 2025-10-09 13:28 ` Rybalchenko, Kirill
  2025-10-09 15:23   ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Rybalchenko, Kirill @ 2025-10-09 13:28 UTC (permalink / raw)
  To: dev@dpdk.org; +Cc: Richardson, Bruce



> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday 30 September 2025 15:29
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [PATCH] net/ice: fix initialization with 8 ports
> 
> When initializing an 8-port device, the ACL configuration
> failed with the adminq returning an ENOMEM status from the
> sixth port onwards. Fix this issue by halving the depth, and
> therefore the space required, when using a device with >4 PFs.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

Acked-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>

>  drivers/net/intel/ice/ice_acl_filter.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/ice/ice_acl_filter.c
> b/drivers/net/intel/ice/ice_acl_filter.c
> index 83cb3e36f9..38e30a4f62 100644
> --- a/drivers/net/intel/ice/ice_acl_filter.c
> +++ b/drivers/net/intel/ice/ice_acl_filter.c
> @@ -114,7 +114,10 @@ ice_acl_setup(struct ice_pf *pf)
>  	else
>  		params.width = ICE_AQC_ACL_KEY_WIDTH_BYTES * 3;
> 
> -	params.depth = ICE_AQC_ACL_TCAM_DEPTH;
> +	if (pf_num > 4)
> +		params.depth = ICE_AQC_ACL_TCAM_DEPTH / 2;
> +	else
> +		params.depth = ICE_AQC_ACL_TCAM_DEPTH;
>  	params.entry_act_pairs = 1;
>  	params.concurr = false;
> 
> --
> 2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/ice: fix initialization with 8 ports
  2025-10-09 13:28 ` Rybalchenko, Kirill
@ 2025-10-09 15:23   ` Bruce Richardson
  0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2025-10-09 15:23 UTC (permalink / raw)
  To: Rybalchenko, Kirill; +Cc: dev@dpdk.org

On Thu, Oct 09, 2025 at 02:28:00PM +0100, Rybalchenko, Kirill wrote:
> 
> 
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Tuesday 30 September 2025 15:29
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>
> > Subject: [PATCH] net/ice: fix initialization with 8 ports
> > 
> > When initializing an 8-port device, the ACL configuration
> > failed with the adminq returning an ENOMEM status from the
> > sixth port onwards. Fix this issue by halving the depth, and
> > therefore the space required, when using a device with >4 PFs.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> 
> Acked-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> 
Applied to dpdk-next-net-intel.

/Bruce

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-09 15:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-30 14:28 [PATCH] net/ice: fix initialization with 8 ports Bruce Richardson
2025-10-09 13:28 ` Rybalchenko, Kirill
2025-10-09 15:23   ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).