From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: dev@dpdk.org, zaiyuwang@trustnetic.com
Subject: Re: [PATCH] net/txgbe: fix the missing old mailbox interface calls
Date: Wed, 19 Nov 2025 21:47:56 -0800 [thread overview]
Message-ID: <20251119214756.6642de30@phoenix.local> (raw)
In-Reply-To: <A4E8D8476CBBC191+20251119085624.73210-1-jiawenwu@trustnetic.com>
On Wed, 19 Nov 2025 16:56:24 +0800
Jiawen Wu <jiawenwu@trustnetic.com> wrote:
> @@ -28,6 +29,9 @@ void txgbe_init_ops_aml40(struct txgbe_hw *hw)
> mac->init_mac_link_ops = txgbe_init_mac_link_ops_aml40;
> mac->get_link_capabilities = txgbe_get_link_capabilities_aml40;
> mac->check_link = txgbe_check_mac_link_aml40;
> +
> + /* MAILBOX */
> + mbx->host_interface_command = txgbe_host_interface_command_aml;
> }
Maybe that comment means something to you, but it seems like something
the next maintainer would not know what it means. Could you explain it more?
next prev parent reply other threads:[~2025-11-20 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 8:56 [PATCH] net/txgbe: fix the missing old mailbox interface calls Jiawen Wu
2025-11-20 5:47 ` Stephen Hemminger [this message]
2025-11-20 6:24 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119214756.6642de30@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).