From: Anurag Mandal <anurag.mandal@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com,
Anurag Mandal <anurag.mandal@intel.com>,
stable@dpdk.org
Subject: [PATCH] net/i40e: fix QinQ stripping
Date: Sat, 6 Dec 2025 18:24:41 +0000 [thread overview]
Message-ID: <20251206182441.68354-1-anurag.mandal@intel.com> (raw)
Outer VLAN strip gets disabled when inner VLAN
stripping is enabled/disabled after enabling outer
VLAN stripping.
This happens because the respective register of
gets overridden by the VSI params update of
inner VLAN stripping.
This patch fixes the issue by re-enabling outer
VLAN stripping after modification of inner
VLAN stripping.
Fixes: c52ff36686a4 ("net/i40e: enable QinQ stripping")
Cc: stable@dpdk.org
Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
---
drivers/net/intel/i40e/i40e_ethdev.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c
index b8ce79061b..c8153f3351 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.c
+++ b/drivers/net/intel/i40e/i40e_ethdev.c
@@ -4150,6 +4150,16 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask)
i40e_vsi_config_vlan_stripping(vsi, TRUE);
else
i40e_vsi_config_vlan_stripping(vsi, FALSE);
+
+ /* When VLAN strip is enabled/disabled
+ * after enabling outer VLAN stripping,
+ * outer VLAN stripping gets disabled
+ * as the register gets overridden by
+ * VLAN's strip vsi param update.
+ * Hence, re-enable outer VLAN stripping.
+ */
+ if (rxmode->offloads & RTE_ETH_RX_OFFLOAD_QINQ_STRIP)
+ i40e_vsi_config_outer_vlan_stripping(vsi, TRUE);
}
if (mask & RTE_ETH_VLAN_EXTEND_MASK) {
--
2.43.0
next reply other threads:[~2025-12-06 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 18:24 Anurag Mandal [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-06 18:43 [PATCH] net/i40e: fix QinQ stripping Anurag Mandal
2025-12-11 14:41 ` Bruce Richardson
2025-12-11 15:58 ` Mandal, Anurag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251206182441.68354-1-anurag.mandal@intel.com \
--to=anurag.mandal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).