From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v4 00/16] lib: find and fix possible string overflows
Date: Sat, 6 Dec 2025 10:43:01 -0800 [thread overview]
Message-ID: <20251206184410.542725-1-stephen@networkplumber.org> (raw)
In-Reply-To: <20251205022948.327743-1-stephen@networkplumber.org>
Change all the libraries to find and fix cases where a string
could overflow when formatting or using strclpy. This does provide
early indication of possible problems where the file prefix is too
long to fit in unix domain socket path, and where a hash table
is being requested that has a name too long.
v4 - fix build on 32 bit and windows
Stephen Hemminger (16):
eal: use C library to parse filesystem table
lpm: restrict name size
hash: add checks for hash name length
graph: avoid overflowing comment buffer
latencystats: add check for string overflow
efd: handle possible name truncation
eal: warn if thread name is truncated
eal: avoid format overflow when handling addresses
eal: add check for sysfs path overflow
eal: limit maximum runtime directory and socket paths
eal: check for hugefile path overflow
eal: check tailq length
eal: handle long shared library path
ethdev: avoid possible overflow in xstat names
vhost: check for overflow in xstat name
lib: enable format overflow warnings
app/test/test_hash.c | 21 ++++++
doc/guides/rel_notes/release_26_03.rst | 3 +
lib/eal/common/eal_common_config.c | 6 +-
lib/eal/common/eal_common_memory.c | 2 +-
lib/eal/common/eal_common_options.c | 17 +++--
lib/eal/common/eal_common_proc.c | 83 ++++++++++++++--------
lib/eal/common/eal_common_tailqs.c | 5 ++
lib/eal/common/eal_filesystem.h | 23 ++++--
lib/eal/freebsd/eal.c | 6 +-
lib/eal/linux/eal.c | 6 +-
lib/eal/linux/eal_hugepage_info.c | 98 ++++++++++++--------------
lib/eal/linux/eal_memalloc.c | 11 ++-
lib/eal/linux/eal_memory.c | 9 ++-
lib/eal/windows/eal.c | 6 +-
lib/efd/rte_efd.c | 7 +-
lib/ethdev/rte_ethdev.c | 35 ++++++---
lib/graph/graph_pcap.c | 9 ++-
lib/hash/rte_cuckoo_hash.c | 41 +++++++----
lib/hash/rte_fbk_hash.c | 14 +++-
lib/latencystats/rte_latencystats.c | 9 ++-
lib/lpm/rte_lpm.c | 25 +++++--
lib/lpm/rte_lpm.h | 2 +-
lib/meson.build | 4 --
lib/vhost/vhost.c | 14 ++--
24 files changed, 303 insertions(+), 153 deletions(-)
--
2.51.0
next prev parent reply other threads:[~2025-12-06 18:44 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 17:24 [RFC 0/8] first steps in fixing buffer overflow Stephen Hemminger
2025-12-02 17:24 ` [RFC 1/8] eal: use C library to parse filesystem table Stephen Hemminger
2025-12-02 17:24 ` [RFC 2/8] hash: fix possible ring name overflow Stephen Hemminger
2025-12-02 17:24 ` [RFC 3/8] eal: warn if thread name is truncated Stephen Hemminger
2025-12-02 17:24 ` [RFC 4/8] eal: avoid format overflow when handling addresses Stephen Hemminger
2025-12-02 17:24 ` [RFC 5/8] ethdev: avoid possible overflow in xstat names Stephen Hemminger
2025-12-02 17:24 ` [RFC 6/8] efd: avoid overflowing ring name Stephen Hemminger
2025-12-02 17:24 ` [RFC 7/8] eal: add check for sysfs path overflow Stephen Hemminger
2025-12-02 17:24 ` [RFC 8/8] eal: limit maximum runtime directory and socket paths Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 00/14] lib: check for string overflow Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 01/14] eal: use C library to parse filesystem table Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 02/14] test: avoid long hash names Stephen Hemminger
2025-12-05 8:29 ` Bruce Richardson
2025-12-05 17:00 ` Stephen Hemminger
2025-12-05 18:19 ` Bruce Richardson
2025-12-05 2:28 ` [RFC v2 03/14] lpm: restrict name size Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 04/14] hash: avoid possible ring name overflow Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 05/14] graph: avoid overflowing comment buffer Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 06/14] eal: warn if thread name is truncated Stephen Hemminger
2025-12-05 8:32 ` Bruce Richardson
2025-12-05 2:28 ` [RFC v2 07/14] eal: avoid format overflow when handling addresses Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 08/14] ethdev: avoid possible overflow in xstat names Stephen Hemminger
2025-12-05 8:34 ` Bruce Richardson
2025-12-05 2:28 ` [RFC v2 09/14] vhost: check for overflow in xstat name Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 10/14] efd: avoid overflowing ring name Stephen Hemminger
2025-12-05 8:37 ` Bruce Richardson
2025-12-05 2:28 ` [RFC v2 11/14] eal: add check for sysfs path overflow Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 12/14] eal: limit maximum runtime directory and socket paths Stephen Hemminger
2025-12-05 8:46 ` Bruce Richardson
2025-12-05 2:28 ` [RFC v2 13/14] eal: check for hugefile path overflow Stephen Hemminger
2025-12-05 2:28 ` [RFC v2 14/14] lib: enable format overflow warnings Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 00/16] lib: find and fix possible string overflows Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 01/16] eal: use C library to parse filesystem table Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 02/16] lpm: restrict name size Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 03/16] hash: add checks for hash name length Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 04/16] graph: avoid overflowing comment buffer Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 05/16] latencystats: add check for string overflow Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 06/16] efd: handle possible name truncation Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 07/16] eal: warn if thread name is truncated Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 08/16] eal: avoid format overflow when handling addresses Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 09/16] eal: add check for sysfs path overflow Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 10/16] eal: limit maximum runtime directory and socket paths Stephen Hemminger
2025-12-08 8:58 ` Bruce Richardson
2025-12-08 19:14 ` Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 11/16] eal: check for hugefile path overflow Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 12/16] eal: check tailq length Stephen Hemminger
2025-12-08 8:58 ` Bruce Richardson
2025-12-05 20:11 ` [PATCH v3 13/16] eal: handle long shared library path Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 14/16] ethdev: avoid possible overflow in xstat names Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 15/16] vhost: check for overflow in xstat name Stephen Hemminger
2025-12-05 20:11 ` [PATCH v3 16/16] lib: enable format overflow warnings Stephen Hemminger
2025-12-06 18:43 ` Stephen Hemminger [this message]
2025-12-06 18:43 ` [PATCH v4 01/16] eal: use C library to parse filesystem table Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 02/16] lpm: restrict name size Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 03/16] hash: add checks for hash name length Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 04/16] graph: avoid overflowing comment buffer Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 05/16] latencystats: add check for string overflow Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 06/16] efd: handle possible name truncation Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 07/16] eal: warn if thread name is truncated Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 08/16] eal: avoid format overflow when handling addresses Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 09/16] eal: add check for sysfs path overflow Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 10/16] eal: limit maximum runtime directory and socket paths Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 11/16] eal: check for hugefile path overflow Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 12/16] eal: check tailq length Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 13/16] eal: handle long shared library path Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 14/16] ethdev: avoid possible overflow in xstat names Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 15/16] vhost: check for overflow in xstat name Stephen Hemminger
2025-12-06 18:43 ` [PATCH v4 16/16] lib: enable format overflow warnings Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 00/17] lib: fix format overflows Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 01/17] eal: use C library to parse filesystem table Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 02/17] lpm: restrict name size Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 03/17] hash: add checks for hash name length Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 04/17] graph: avoid overflowing comment buffer Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 05/17] latencystats: add check for string overflow Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 06/17] telemetry: avoid possible " Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 07/17] efd: handle possible name truncation Stephen Hemminger
2025-12-07 19:11 ` [PATCH v5 08/17] eal: warn if thread name is truncated Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 09/17] eal: avoid format overflow when handling addresses Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 10/17] eal: add check for sysfs path overflow Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 11/17] eal: limit maximum runtime directory and socket paths Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 12/17] eal: check for hugefile path overflow Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 13/17] eal: check tailq length Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 14/17] eal: handle long shared library path Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 15/17] ethdev: avoid possible overflow in xstat names Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 16/17] vhost: check for overflow in xstat name Stephen Hemminger
2025-12-07 19:12 ` [PATCH v5 17/17] lib: enable format overflow warnings Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251206184410.542725-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).