Re: [PATCH v9 01/14] net/sxe: add base driver directory and doc

David Marchand
2025-07-16T08:42:23Z

Hello,

On Wed, Jul 16, 2025 at 10:29 AM Jie Liu <liujie5@linkdatatechnology.com> wrote:
>
> Adding a minimum maintainable directory structure for the
> network driver and request maintenance of the sxe driver.
>
> Signed-off-by: Jie Liu <liujie5@linkdatatechnology.com>

- Such a big series deserves a cover letter, with annotations/tracking
of the changes across the revisions.

- I did not look in detail but I noticed a .map file.
Driver specific API should be avoided as much as possible.

But if it is really necessary, please look at the recent changes wrt
symbol exports since .map are not used anymore.
Example of a conversion:
$ git diff v25.03 -- drivers/baseband/acc/
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index d33e42c807..b7f02f56e1 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -4,6 +4,7 @@

#include <unistd.h>

+#include <eal_export.h>
#include <rte_common.h>
#include <rte_log.h>
#include <dev_driver.h>
@@ -4635,6 +4636,7 @@ acc100_configure(const char *dev_name, struct
rte_acc_conf *conf)
return 0;
}

+RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_acc_configure, 22.11)
int
rte_acc_configure(const char *dev_name, struct rte_acc_conf *conf)
{
diff --git a/drivers/baseband/acc/version.map b/drivers/baseband/acc/version.map
deleted file mode 100644
index 3f427caf67..0000000000
--- a/drivers/baseband/acc/version.map
+++ /dev/null
@@ -1,10 +0,0 @@
-DPDK_25 {
- local: *;
-};
-
-EXPERIMENTAL {
- global:
-
- # added in 22.11
- rte_acc_configure;
-};

--
David Marchand