Re: [PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function

Stephen Hemminger
2025-07-09T16:13:46Z

On Wed, 9 Jul 2025 04:43:04 -0400
Jie Liu <liujie5@linkdatatechnology.com> wrote:

> + RTE_ATOMIC(bool)link_thread_running;
> + RTE_ATOMIC(bool)is_stopping;

Despite what checkpatch says, need space here:
RTE_ATOMIC(bool) is_stopping;

> + rte_thread_t link_thread_tid;
> + rte_atomic32_t link_thread_running;

Don't use old rte atomics, instead use RTE_ATOMIC() consistently

> + rte_atomic32_t is_stopping;
> + pthread_t link_thread_tid;

Two struct elements with same name, how does that work?

> + bool is_stopped;