Re: [PATCH v4 04/35] net/intel: consolidate definitions for Tx desc fields

Burakov, Anatoly
2026-02-10T12:26:33Z

On 2/9/2026 5:45 PM, Bruce Richardson wrote:
> The offsets of the various fields within the Tx descriptors are common
> for i40e, iavf, ice and idpf, so put a single set of defines in tx.h and
> use those throughout all drivers. (NOTE: there was a small difference in
> mask of CMD field between drivers depending on whether reserved fields
> or not were included. Those can be ignored as those bits are unused in
> the drivers for which they are reserved). Similarly, the various flag
> fields, such as End-of-packet (EOP) and Report-status (RS) are the same,
> as are offload definitions so consolidate them.

Nitpick: the NOTE should IMO be separated, as otherwise the flow of the
commit message is a bit confusing, as the latter part kinda parses as
being part of the NOTE section that accidentally got left out of the
parens, instead of being a continuation of the pre-NOTE section.

Otherwise, LGTM

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

--
Thanks,
Anatoly