Re: [PATCH v4 22/35] net/intel: mark mid-burst ring cleanup as unlikely

Bruce Richardson
2026-02-10T14:13:58Z

On Tue, Feb 10, 2026 at 02:36:56PM +0100, Burakov, Anatoly wrote:
> On 2/9/2026 5:45 PM, Bruce Richardson wrote:
> > It should rarely be the case that we need to cleanup the descriptor ring
> > mid-burst, so mark as unlikely to help performance.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
>
> Does it measurably help performance? I'm by no means a performance person so
> this isn't really my wheelhouse, but I remember enough patches removing
> "unlikely() for performance reasons" to get suspicious!
>
> --
Yes, I tend to be suspicous too. I will reverify and, if not measurable,
will drop this patch from the set.

/Bruce