Re: [PATCH v5 6/8] build: reduce driver dependencies

David Marchand
2024-12-16T16:07:02Z

On Wed, Nov 27, 2024 at 5:20 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 11/27/2024 3:56 PM, Anatoly Burakov wrote:
> > From: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Remove any unnecessary dependencies from the driver dependency lists.
> > This will give each driver a near-minimum set of required dependencies.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Reviewed-by: Rosen Xu <rosen.xu@intel.com>
> > ---
>
>
> > diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
> > index 5a8de16fe0..5ffb56fc93 100644
> > --- a/drivers/common/qat/meson.build
> > +++ b/drivers/common/qat/meson.build
> > @@ -71,7 +71,7 @@ else
> > endif
> > endif
> >
> > -deps += ['bus_pci', 'cryptodev', 'net', 'compressdev']
> > +deps += ['bus_pci']
> > sources += files(
> > 'qat_common.c',
> > 'qat_qp.c',
> > @@ -101,6 +101,7 @@ if qat_compress
> > ]
> > sources += files(join_paths(qat_compress_relpath, f))
> > endforeach
> > + deps += ['compressdev']
> > endif
> >
> > if qat_crypto
>
> Seems that these changes were overly aggressive and cause build
> failures. Will fix in v6.

Indeed, some crypto-related headers still get included in "common" code.

--
David Marchand