RE: [PATCH v4 6/8] build: reduce driver dependencies

Xu, Rosen
2024-11-27T02:17:29Z

Hi,

> -----Original Message-----
> From: Burakov, Anatoly <anatoly.burakov@intel.com>
> Sent: Tuesday, November 26, 2024 10:40 PM
> To: dev@dpdk.org; Chautru, Nicolas <nicolas.chautru@intel.com>;
> Gagandeep Singh <g.singh@nxp.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Parav Pandit <parav@nvidia.com>; Xueming Li
> <xuemingl@nvidia.com>; Sachin Saxena <sachin.saxena@nxp.com>; Xu,
> Rosen <rosen.xu@intel.com>; Chenbo Xia <chenbox@nvidia.com>; Nipun
> Gupta <nipun.gupta@amd.com>; Tomasz Duszynski
> <tduszynski@marvell.com>; Chengwen Feng
> <fengchengwen@huawei.com>; Nithin Dabilpuram
> <ndabilpuram@marvell.com>; Kiran Kumar K <kirankumark@marvell.com>;
> Sunil Kumar Kori <skori@marvell.com>; Satha Rao
> <skoteshwar@marvell.com>; Harman Kalra <hkalra@marvell.com>; Anoob
> Joseph <anoobj@marvell.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Shetty, Praveen <praveen.shetty@intel.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>;
> Bing Zhao <bingz@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming
> Mou <suanmingm@nvidia.com>; Matan Azrad <matan@nvidia.com>; Fan
> Zhang <fanzhang.oss@gmail.com>; Ashish Gupta
> <ashish.gupta@marvell.com>; Nagadheeraj Rottela
> <rnagadheeraj@marvell.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Vikas Gupta
> <vikas.gupta@broadcom.com>; Ankur Dwivedi <adwivedi@marvell.com>;
> Tejasree Kondoj <ktejasree@marvell.com>; Ji, Kai <kai.ji@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Srikanth Jampala
> <jsrikanth@marvell.com>; Vamsi Attunuru <vattunuru@marvell.com>;
> Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>; Vidya Sagar
> Velumuri <vvelumuri@marvell.com>; Laatz, Kevin <kevin.laatz@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Pavan Nikhilesh
> <pbhagavatula@marvell.com>; Shijith Thotton <sthotton@marvell.com>;
> Pathak, Pravin <pravin.pathak@intel.com>; Jerin Jacob
> <jerinj@marvell.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> Ashwin Sekhar T K <asekhar@marvell.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>; Stokes, Ian <ian.stokes@intel.com>; Long
> Li <longli@microsoft.com>; Wei Hu <weh@microsoft.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Jakub Palider <jpalider@marvell.com>;
> Vijay Kumar Srivastava <vsrivast@xilinx.com>
> Subject: [PATCH v4 6/8] build: reduce driver dependencies
>
> From: Bruce Richardson <bruce.richardson@intel.com>
>
> Remove any unnecessary dependencies from the driver dependency lists.
> This will give each driver a near-minimum set of required dependencies.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/bus/ifpga/meson.build | 2 +-
> diff --git a/drivers/bus/ifpga/meson.build b/drivers/bus/ifpga/meson.build
> index dedc94db2d..e87b08eaf4 100644
> --- a/drivers/bus/ifpga/meson.build
> +++ b/drivers/bus/ifpga/meson.build
> @@ -7,6 +7,6 @@ if is_windows
> subdir_done()
> endif
>
> -deps += ['pci', 'kvargs', 'rawdev']
> +deps = ['pci', 'rawdev']
> driver_sdk_headers += files('bus_ifpga_driver.h') sources =
> files('ifpga_bus.c') diff --git a/drivers/bus/pci/meson.build
> b/drivers/bus/pci/meson.build index fede114dc7..776c3d1550 100644

Reviewed-by: Rosen Xu <rosen.xu@intel.com>