Re: [PATCH v3 1/8] build: split dependencies into mandatory and optional

Bruce Richardson
2024-09-09T09:01:40Z

On Mon, Sep 09, 2024 at 10:41:25AM +0200, Burakov, Anatoly wrote:
> On 9/6/2024 4:51 PM, Bruce Richardson wrote:
> > On Wed, Sep 04, 2024 at 04:08:29PM +0100, Anatoly Burakov wrote:
> > > Allow specifying dependencies as either mandatory or optional. This does
> > > not change anything about the build, but it is useful for tooling to know
> > > if a dependency is required or not.
> > >
> >
> > Ideally we probably want to merge the support in this patch with the idea
> > expressed in [1]
> >
> > /Bruce
> >
> > [1] https://patches.dpdk.org/project/dpdk/patch/20231220142152.492556-4-bruce.richardson@intel.com/
>
> Hi Bruce,
>
> Please correct me if I'm wrong, but doesn't it essentially do the same
> thing? You're adding a new loop over optional deps, while I'm simply
> extending existing loop to iterate over deps + optional deps, which would
> achieve the same thing?
>
> What does that patch do that this patch doesn't?
>
Your patch categorises the dependencies into optional and mandatory but
doesn't actually change any code flow logic. My patch doesn't do the
classification changes in the individual components, but changes the higher
level meson.build file to do the checks for optional dependencies and only
add them if they are present. That is, it removes the need for individual
components to check for the optional deps themselves and add them if found.

/Bruce