Re: [RFC PATCH v2 02/33] eal: fix variable shadowing

fengchengwen
2025-11-10T01:00:01Z

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 11/7/2025 11:49 PM, Bruce Richardson wrote:
> Fix a range of variable shadowing issues flagged by -Wshadow:
>
> * In tracing code, rename local variables to remove shadowing in the
> code. The file-level variable "trace" is kept as-is, but the shorter
> name "t" is used for function-local vars.
> * In options code, rename the "args" variable to "out_args" in the
> telemetry callback, to fix shadowing issues there.
> * In malloc code, remove the redefinition of aligned_end, and just use
> the already-defined local variable in the last block of code in the
> function.
>
> Bugzilla ID: 1742
> Bugzilla ID: 1743
> Fixes: 29d985cad8db ("trace: implement memory allocation")
> Fixes: f330b01df996 ("eal: define the parameters in argparse format")
> Fixes: 4d8bdd8b56a1 ("malloc: fix ASan handling for unmapped memory")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>