Re: [PATCH v3 00/31] build DPDK with Wshadow flag

Bruce Richardson
2025-12-01T11:49:56Z

On Mon, Dec 01, 2025 at 11:44:17AM +0000, Bruce Richardson wrote:
> As flagged in bugs #1742, #1743 and others, much of DPDK fails to build
> when -Wshadow flag is passed to the build. This patchset fixes many issues
> of this nature, but not all, in the hopes we can move towards enabling that
> warning flag for all components for DPDK in future. This patchset fixes the
> following components in DPDK:
>
> * all libraries
> * Intel net drivers
> * all apps in the "app" folder
>
> For the rest of the drivers and example applications, any component which
> does not build successfully with the shadow warning enabled has it
> explicitly disabled via cflags. Then the last patch adds -Wshadow to the
> global DPDK build, which should prevent any regressions in components which
> are already working.
>
> At that point, we should not have any regressions and we can, over time,
> reduce the number of components needing the -Wno-shadow flag.
>
> v3:
> * rebase on 25.11 release.
>
@stable tree maintainers.

Where feasible, for many of the patches in this set, I've marked them as
bug fixes against older commits which introduced the shadowing. However,
I'll leave it up to you to decide if it's worth backporting this particular
series or not. The remaining commits which are not tagged as fixes or which
don't have offending commits identified should probably be backported too
if you are backporting any. IMHO, I don't see much point in backporting
only part of the series - either it should all be backported (bar last
patch) or none of it.

Regards,
/Bruce