Re: [RFC PATCH 10/19] telemetry: make socket handler typedef private

fengchengwen
2025-11-07T02:43:13Z

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 11/6/2025 10:09 PM, Bruce Richardson wrote:
> The socket handler typedef, just called "handler" does not belong in the
> public namespace, especially since it is unprefixed. Rename to
> "telemetry_sock_handler" and move to internal header.
>
> Doing so also clears shadowing warnings in dmadev library, when it is
> built with -Wshadow.
>
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>