[PATCH v3 14/31] net/i40e: fix build with shadow warnings enabled

Bruce Richardson
2025-12-01T11:46:48Z

The local variables defined with the I40E_WRITE_GLB_REG macro are
shadowing other variables. Rename the vars to start with "_" to avoid
this shadowing.

Fixes: 2bedd7277a10 ("net/i40e: print real global changes")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/intel/i40e/i40e_ethdev.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/intel/i40e/i40e_ethdev.h b/drivers/net/intel/i40e/i40e_ethdev.h
index 3fca089d6c..70dc506037 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.h
+++ b/drivers/net/intel/i40e/i40e_ethdev.h
@@ -92,11 +92,11 @@
#define I40E_WRITE_GLB_REG(hw, reg, value) \
do { \
uint32_t ori_val; \
- struct rte_eth_dev *dev; \
- struct rte_eth_dev_data *dev_data; \
+ struct rte_eth_dev *_dev; \
+ struct rte_eth_dev_data *_dev_data; \
ori_val = I40E_READ_REG((hw), (reg)); \
- dev_data = ((struct i40e_adapter *)hw->back)->pf.dev_data; \
- dev = &rte_eth_devices[dev_data->port_id]; \
+ _dev_data = ((struct i40e_adapter *)hw->back)->pf.dev_data; \
+ _dev = &rte_eth_devices[_dev_data->port_id]; \
I40E_PCI_REG_WRITE(I40E_PCI_REG_ADDR((hw), \
(reg)), (value)); \
if (ori_val != value) \
@@ -104,7 +104,7 @@
"i40e device %s changed global " \
"register [0x%08x]. original: 0x%08x, " \
"new: 0x%08x ", \
- (dev->device->name), (reg), \
+ (_dev->device->name), (reg), \
(ori_val), (value)); \
} while (0)

--
2.51.0