public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>, stable@dpdk.org
Subject: [PATCH 2/3] net/ice: fix priority mode printing in Tx scheduler dump
Date: Thu, 15 Jan 2026 10:38:22 +0000	[thread overview]
Message-ID: <20260115103824.1982220-3-ciara.loftus@intel.com> (raw)
In-Reply-To: <20260115103824.1982220-1-ciara.loftus@intel.com>

A value of zero in bit 4 of the generic data means that strict priority
is enabled. Prior to this commit it was being interpreted as WFQ being
enabled. Fix this.

Fixes: ab4eaf9a8a31 ("net/ice: dump Tx scheduling tree")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 drivers/net/intel/ice/ice_diagnose.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/ice/ice_diagnose.c b/drivers/net/intel/ice/ice_diagnose.c
index 298d1eda5c..a58279a116 100644
--- a/drivers/net/intel/ice/ice_diagnose.c
+++ b/drivers/net/intel/ice/ice_diagnose.c
@@ -641,7 +641,7 @@ void print_node(const struct rte_eth_dev_data *ethdata,
 	fprintf(stream, "\t\t\t\t<tr>\n");
 	fprintf(stream, "\t\t\t\t\t<td> priority mode</td>\n");
 	fprintf(stream, "\t\t\t\t\t<td>");
-	print_priority_mode(stream, ((data->data.generic >> 4) & 0x1) != 0);
+	print_priority_mode(stream, ((data->data.generic >> 4) & 0x1) == 0);
 	fprintf(stream,	"</td>\n");
 	fprintf(stream, "\t\t\t\t</tr>\n");
 
-- 
2.43.0


  parent reply	other threads:[~2026-01-15 10:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 10:38 [PATCH 0/3] Ice Tx Scheduler Fixes Ciara Loftus
2026-01-15 10:38 ` [PATCH 1/3] net/ice: check for null before dereferencing Ciara Loftus
2026-01-15 10:41   ` Bruce Richardson
2026-01-15 10:38 ` Ciara Loftus [this message]
2026-01-15 10:55   ` [PATCH 2/3] net/ice: fix priority mode printing in Tx scheduler dump Bruce Richardson
2026-01-15 10:38 ` [PATCH 3/3] net/ice: re-enable strict priority on non-root levels Ciara Loftus
2026-01-15 10:42   ` Bruce Richardson
2026-01-16 14:33 ` [PATCH 0/3] Ice Tx Scheduler Fixes Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115103824.1982220-3-ciara.loftus@intel.com \
    --to=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox