From: Stephen Hemminger <stephen@networkplumber.org>
To: coolwilled <coolwilled@gmail.com>
Cc: dev@dpdk.org, users@dpdk.org
Subject: Re: Bug: crypto_snow3g failed in Auth snow3g + Cipher snow3g
Date: Fri, 16 Jan 2026 08:45:53 -0800 [thread overview]
Message-ID: <20260116084553.681355b0@phoenix.local> (raw)
In-Reply-To: <CAL2ZP-A=cnXozqacMbDUKd15KgHifSmBjqNDN+o340yJ+3t99w@mail.gmail.com>
On Fri, 16 Jan 2026 18:45:15 +0800
coolwilled <coolwilled@gmail.com> wrote:
> Hi,
> I run "pdcp_autotest" with --vdev=crypto_snow3g in app/dpdk-test in dpdk
> v25.11.
> When i = 42 in run_test_for_one_know_vec() in test_pdcp.c,
> It is PDCP control plane Auth snow3g gen + Cipher sonw3g enc,
> the case failed because the last 4 bytes is cleared in
> last for() loop in line 167 in process_snow3g_cipher_op() in pmd_snow3g.c .
>
> It can be fixed with following change:
>
> diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c
> b/drivers/crypto/ipsec_mb/pmd_snow3g.c
> index b3c3b05a8a..45a8be5fc8 100644
> --- a/drivers/crypto/ipsec_mb/pmd_snow3g.c
> +++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c
> @@ -157,7 +157,7 @@ process_snow3g_cipher_op(struct ipsec_mb_qp *qp, struct
> rte_crypto_op **ops,
> for (i = 0; i < num_ops; i++) {
> if ((session->op == IPSEC_MB_OP_HASH_VERIFY_THEN_DECRYPT ||
> session->op == IPSEC_MB_OP_HASH_GEN_THEN_ENCRYPT) &&
> - ops[i]->sym->m_dst != NULL) {
> + ops[i]->sym->m_dst != NULL &&
> ops[i]->sym->m_dst != ops[i]->sym->m_src) {
> digest_appended[i] =
> snow3g_digest_appended_in_src(ops[i]);
> /* Clear unencrypted digest from
Please turn this into a patch and use the process described in DPDK
contribution documentation.
next prev parent reply other threads:[~2026-01-16 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 10:45 Bug: crypto_snow3g failed in Auth snow3g + Cipher snow3g coolwilled
2026-01-16 16:45 ` Stephen Hemminger [this message]
2026-01-16 17:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116084553.681355b0@phoenix.local \
--to=stephen@networkplumber.org \
--cc=coolwilled@gmail.com \
--cc=dev@dpdk.org \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox