public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: spinler@cesnet.cz
To: dev@dpdk.org
Cc: Martin Spinler <spinler@cesnet.cz>
Subject: [PATCH v2 1/8] net/nfb: prepare for indirect queue mapping scheme
Date: Fri, 16 Jan 2026 17:44:29 +0100	[thread overview]
Message-ID: <20260116164436.1649047-2-spinler@cesnet.cz> (raw)
In-Reply-To: <20260116164436.1649047-1-spinler@cesnet.cz>

From: Martin Spinler <spinler@cesnet.cz>

This prepares queue mapping for port-aware driver implementation.

Signed-off-by: Martin Spinler <spinler@cesnet.cz>
---
 drivers/net/nfb/nfb.h        |  4 ++++
 drivers/net/nfb/nfb_ethdev.c | 19 +++++++++++++++++++
 drivers/net/nfb/nfb_rx.c     | 21 ++++++++++++---------
 drivers/net/nfb/nfb_tx.c     | 21 ++++++++++++---------
 4 files changed, 47 insertions(+), 18 deletions(-)

diff --git a/drivers/net/nfb/nfb.h b/drivers/net/nfb/nfb.h
index 09d4b7da5f..0361859fc1 100644
--- a/drivers/net/nfb/nfb.h
+++ b/drivers/net/nfb/nfb.h
@@ -47,6 +47,10 @@ struct pmd_internals {
 	uint16_t         max_txmac;
 	struct nc_rxmac *rxmac[RTE_MAX_NC_RXMAC];
 	struct nc_txmac *txmac[RTE_MAX_NC_TXMAC];
+
+	int             *queue_map_rx;
+	int             *queue_map_tx;
+
 	struct nfb_device *nfb;
 };
 
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index 59d9987789..238a3004c5 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -509,6 +509,7 @@ static const struct eth_dev_ops ops = {
 static int
 nfb_eth_dev_init(struct rte_eth_dev *dev)
 {
+	int i;
 	int ret;
 	uint32_t mac_count;
 	struct rte_eth_dev_data *data = dev->data;
@@ -566,6 +567,21 @@ nfb_eth_dev_init(struct rte_eth_dev *dev)
 	dev->rx_pkt_burst = nfb_eth_ndp_rx;
 	dev->tx_pkt_burst = nfb_eth_ndp_tx;
 
+	internals->queue_map_rx = rte_malloc("NFB queue map",
+			sizeof(*internals->queue_map_rx) *
+			(priv->max_rx_queues + priv->max_tx_queues), 0);
+	if (internals->queue_map_rx == NULL) {
+		ret = -ENOMEM;
+		goto err_alloc_queue_map;
+	}
+	internals->queue_map_tx = internals->queue_map_rx + priv->max_rx_queues;
+
+	/* default queue mapping is 1:1 */
+	for (i = 0; i < priv->max_rx_queues; i++)
+		internals->queue_map_rx[i] = i;
+	for (i = 0; i < priv->max_tx_queues; i++)
+		internals->queue_map_tx[i] = i;
+
 	/* Set function callbacks for Ethernet API */
 	dev->dev_ops = &ops;
 
@@ -604,6 +620,8 @@ nfb_eth_dev_init(struct rte_eth_dev *dev)
 	return 0;
 
 err_malloc_mac_addrs:
+	rte_free(internals->queue_map_rx);
+err_alloc_queue_map:
 	nfb_nc_rxmac_deinit(internals->rxmac, internals->max_rxmac);
 	nfb_nc_txmac_deinit(internals->txmac, internals->max_txmac);
 	nfb_close(internals->nfb);
@@ -634,6 +652,7 @@ nfb_eth_dev_uninit(struct rte_eth_dev *dev)
 	nfb_nc_txmac_deinit(internals->txmac, internals->max_txmac);
 	nfb_close(internals->nfb);
 
+	rte_free(internals->queue_map_rx);
 	rte_free(internals);
 
 	NFB_LOG(INFO, "NFB device (" PCI_PRI_FMT ") successfully uninitialized",
diff --git a/drivers/net/nfb/nfb_rx.c b/drivers/net/nfb/nfb_rx.c
index 413d275853..dba5755bdc 100644
--- a/drivers/net/nfb/nfb_rx.c
+++ b/drivers/net/nfb/nfb_rx.c
@@ -63,6 +63,7 @@ nfb_eth_rx_queue_setup(struct rte_eth_dev *dev,
 	struct pmd_internals *internals = dev->process_private;
 
 	struct ndp_rx_queue *rxq;
+	int nfb_qid;
 	int ret;
 
 	rxq = rte_zmalloc_socket("ndp rx queue",
@@ -77,17 +78,19 @@ nfb_eth_rx_queue_setup(struct rte_eth_dev *dev,
 
 	rxq->flags = 0;
 
-	ret = nfb_eth_rx_queue_init(internals->nfb,
-		rx_queue_id,
-		dev->data->port_id,
-		mb_pool,
-		rxq);
+	/* nfb queue id doesn't necessary corresponds to txq_id */
+	nfb_qid = internals->queue_map_rx[rx_queue_id];
 
-	if (ret == 0)
-		dev->data->rx_queues[rx_queue_id] = rxq;
-	else
-		rte_free(rxq);
+	ret = nfb_eth_rx_queue_init(internals->nfb, nfb_qid,
+			dev->data->port_id, mb_pool, rxq);
+	if (ret)
+		goto err_queue_init;
+
+	dev->data->rx_queues[rx_queue_id] = rxq;
+	return 0;
 
+err_queue_init:
+	rte_free(rxq);
 	return ret;
 }
 
diff --git a/drivers/net/nfb/nfb_tx.c b/drivers/net/nfb/nfb_tx.c
index 1f997ce22f..8ea62ec62c 100644
--- a/drivers/net/nfb/nfb_tx.c
+++ b/drivers/net/nfb/nfb_tx.c
@@ -55,10 +55,10 @@ nfb_eth_tx_queue_setup(struct rte_eth_dev *dev,
 {
 	struct pmd_internals *internals = dev->process_private;
 	int ret;
+	int nfb_qid;
 	struct ndp_tx_queue *txq;
 
-	txq = rte_zmalloc_socket("ndp tx queue",
-		sizeof(struct ndp_tx_queue),
+	txq = rte_zmalloc_socket("ndp tx queue", sizeof(struct ndp_tx_queue),
 		RTE_CACHE_LINE_SIZE, socket_id);
 
 	if (txq == NULL) {
@@ -67,15 +67,18 @@ nfb_eth_tx_queue_setup(struct rte_eth_dev *dev,
 		return -ENOMEM;
 	}
 
-	ret = nfb_eth_tx_queue_init(internals->nfb,
-		tx_queue_id,
-		txq);
+	/* nfb queue id doesn't necessary corresponds to tx_queue_id */
+	nfb_qid = internals->queue_map_tx[tx_queue_id];
 
-	if (ret == 0)
-		dev->data->tx_queues[tx_queue_id] = txq;
-	else
-		rte_free(txq);
+	ret = nfb_eth_tx_queue_init(internals->nfb, nfb_qid, txq);
+	if (ret)
+		goto err_queue_init;
+
+	dev->data->tx_queues[tx_queue_id] = txq;
+	return 0;
 
+err_queue_init:
+	rte_free(txq);
 	return ret;
 }
 
-- 
2.52.0


  reply	other threads:[~2026-01-16 16:44 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 15:16 [PATCH 0/8] net/nfb: rework to real multiport spinler
2026-01-15 15:16 ` [PATCH 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-01-16 17:34   ` Stephen Hemminger
2026-01-20 15:16     ` Martin Spinler
2026-01-15 15:16 ` [PATCH 2/8] net/nfb: create ethdev for every eth port/channel spinler
2026-01-15 15:16 ` [PATCH 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-01-15 15:16 ` [PATCH 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-01-16 17:36   ` Stephen Hemminger
2026-01-20 15:16     ` Martin Spinler
2026-01-16 17:36   ` Stephen Hemminger
2026-01-16 17:37   ` Stephen Hemminger
2026-01-15 15:16 ` [PATCH 5/8] net/nfb: init only MACs associated with device spinler
2026-01-15 15:16 ` [PATCH 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-01-15 15:16 ` [PATCH 7/8] net/nfb: report firmware version spinler
2026-01-15 15:16 ` [PATCH 8/8] doc/nfb: cleanup and update guide spinler
2026-01-16  5:50 ` [PATCH 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-01-16 16:44 ` [PATCH v2 " spinler
2026-01-16 16:44   ` spinler [this message]
2026-01-16 16:44   ` [PATCH v2 2/8] net/nfb: create ethdev for every eth port/channel spinler
2026-01-16 16:44   ` [PATCH v2 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-01-16 16:44   ` [PATCH v2 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-01-16 16:44   ` [PATCH v2 5/8] net/nfb: init only MACs associated with device spinler
2026-01-16 16:44   ` [PATCH v2 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-01-16 16:44   ` [PATCH v2 7/8] net/nfb: report firmware version spinler
2026-01-16 16:44   ` [PATCH v2 8/8] doc/nfb: cleanup and update guide spinler
2026-01-20  2:25   ` [PATCH v2 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-01-20 15:16     ` Martin Spinler
2026-01-21 17:03 ` [PATCH v3 " spinler
2026-01-21 17:03   ` [PATCH v3 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-01-21 17:03   ` [PATCH v3 2/8] net/nfb: create ethdev for every eth port/channel spinler
2026-01-21 17:03   ` [PATCH v3 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-01-21 17:40     ` Stephen Hemminger
2026-01-21 17:03   ` [PATCH v3 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-01-21 17:03   ` [PATCH v3 5/8] net/nfb: init only MACs associated with device spinler
2026-01-21 17:03   ` [PATCH v3 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-01-21 17:03   ` [PATCH v3 7/8] net/nfb: report firmware version spinler
2026-01-21 17:03   ` [PATCH v3 8/8] doc/nfb: cleanup and update guide spinler
2026-01-21 17:41     ` Stephen Hemminger
2026-01-21 17:42   ` [PATCH v3 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-01-22  7:27 ` [PATCH v4 " spinler
2026-01-22  7:27   ` [PATCH v4 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-01-22  7:27   ` [PATCH v4 2/8] net/nfb: create ethdev for every eth port/channel spinler
2026-01-22  7:27   ` [PATCH v4 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-01-22  7:27   ` [PATCH v4 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-01-22  7:27   ` [PATCH v4 5/8] net/nfb: init only MACs associated with device spinler
2026-01-22  7:27   ` [PATCH v4 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-01-22  7:27   ` [PATCH v4 7/8] net/nfb: report firmware version spinler
2026-01-22  7:27   ` [PATCH v4 8/8] doc/nfb: cleanup and update guide spinler
2026-01-23  1:00   ` [PATCH v4 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-01-23  1:01   ` Stephen Hemminger
2026-01-23  1:14   ` Stephen Hemminger
2026-01-23 17:34     ` Martin Spinler
2026-01-23 17:22 ` [PATCH v5 " spinler
2026-01-23 17:22   ` [PATCH v5 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-01-23 17:22   ` [PATCH v5 2/8] net/nfb: create one ethdev per ethernet port spinler
2026-01-27  0:37     ` Stephen Hemminger
2026-01-27  8:12       ` Martin Spinler
2026-01-27 14:09         ` Stephen Hemminger
2026-01-23 17:22   ` [PATCH v5 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-01-23 17:22   ` [PATCH v5 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-01-23 17:22   ` [PATCH v5 5/8] net/nfb: init only MACs associated with device spinler
2026-01-23 17:22   ` [PATCH v5 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-01-23 17:22   ` [PATCH v5 7/8] net/nfb: report firmware version spinler
2026-01-23 17:22   ` [PATCH v5 8/8] doc/nfb: cleanup and update guide spinler
2026-01-24 19:10     ` [REVIEW] " Stephen Hemminger
2026-01-24 19:19   ` [PATCH v5 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-02-02 15:34 ` [PATCH v6 " spinler
2026-02-02 15:34   ` [PATCH v6 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-02-02 17:50     ` Stephen Hemminger
2026-02-02 15:34   ` [PATCH v6 2/8] net/nfb: create one ethdev per ethernet port spinler
2026-02-02 15:34   ` [PATCH v6 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-02-02 15:34   ` [PATCH v6 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-02-02 15:34   ` [PATCH v6 5/8] net/nfb: init only MACs associated with device spinler
2026-02-02 15:34   ` [PATCH v6 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-02-02 15:34   ` [PATCH v6 7/8] net/nfb: report firmware version spinler
2026-02-02 15:34   ` [PATCH v6 8/8] doc/nfb: cleanup and update guide spinler
2026-02-02 17:42     ` [REVIEW] " Stephen Hemminger
2026-02-02 17:51       ` Stephen Hemminger
2026-02-02 17:52       ` Stephen Hemminger
2026-02-02 17:54       ` Stephen Hemminger
2026-02-02 17:54       ` Stephen Hemminger
2026-02-04 12:31 ` [PATCH v7 0/8] net/nfb: rework to real multiport spinler
2026-02-04 12:31   ` [PATCH v7 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-02-04 12:31   ` [PATCH v7 2/8] net/nfb: create one ethdev per ethernet port spinler
2026-02-04 12:31   ` [PATCH v7 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-02-04 12:31   ` [PATCH v7 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-02-04 12:31   ` [PATCH v7 5/8] net/nfb: init only MACs associated with device spinler
2026-02-04 12:31   ` [PATCH v7 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-02-04 12:31   ` [PATCH v7 7/8] net/nfb: report firmware version spinler
2026-02-04 12:31   ` [PATCH v7 8/8] doc/nfb: cleanup and update guide spinler
2026-02-10  0:35   ` [PATCH v7 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-02-13 18:53     ` Martin Špinler
2026-02-12 18:35   ` Stephen Hemminger
2026-02-13 18:53     ` Martin Špinler
2026-02-13 18:53 ` [PATCH v8 " spinler
2026-02-13 18:53   ` [PATCH v8 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-02-13 18:53   ` [PATCH v8 2/8] net/nfb: create one ethdev per ethernet port spinler
2026-02-13 19:33     ` Stephen Hemminger
2026-02-13 18:53   ` [PATCH v8 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-02-13 18:53   ` [PATCH v8 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-02-13 18:53   ` [PATCH v8 5/8] net/nfb: init only MACs associated with device spinler
2026-02-13 18:53   ` [PATCH v8 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-02-13 18:53   ` [PATCH v8 7/8] net/nfb: report firmware version spinler
2026-02-13 18:53   ` [PATCH v8 8/8] doc/nfb: cleanup and update guide spinler
2026-02-13 19:39   ` [PATCH v8 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-02-13 20:13     ` Martin Špinler
2026-02-16 16:24 ` [PATCH v9 " spinler
2026-02-16 16:24   ` [PATCH v9 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-02-16 16:25   ` [PATCH v9 2/8] net/nfb: create one ethdev per ethernet port spinler
2026-02-16 16:25   ` [PATCH v9 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-02-16 16:25   ` [PATCH v9 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-02-16 16:25   ` [PATCH v9 5/8] net/nfb: init only MACs associated with device spinler
2026-02-16 16:25   ` [PATCH v9 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-02-16 16:25   ` [PATCH v9 7/8] net/nfb: report firmware version spinler
2026-02-16 16:25   ` [PATCH v9 8/8] doc/nfb: cleanup and update guide spinler
2026-02-16 22:11   ` [PATCH v9 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-02-17  7:09     ` Martin Spinler
2026-02-17  7:10 ` [PATCH v10 " spinler
2026-02-17  7:10   ` [PATCH v10 1/8] net/nfb: prepare for indirect queue mapping scheme spinler
2026-02-17  7:10   ` [PATCH v10 2/8] net/nfb: create one ethdev per ethernet port spinler
2026-02-17  7:10   ` [PATCH v10 3/8] net/nfb: add vdev as alternative device probe method spinler
2026-02-17  7:10   ` [PATCH v10 4/8] net/nfb: add device argument "port" to limit used ports spinler
2026-02-17  7:10   ` [PATCH v10 5/8] net/nfb: init only MACs associated with device spinler
2026-02-17  7:10   ` [PATCH v10 6/8] net/nfb: add compatible cards to driver PCI ID table spinler
2026-02-17  7:10   ` [PATCH v10 7/8] net/nfb: report firmware version spinler
2026-02-17  7:10   ` [PATCH v10 8/8] doc/nfb: cleanup and update guide spinler
2026-03-13 16:48     ` Thomas Monjalon
2026-02-17 14:58   ` [PATCH v10 0/8] net/nfb: rework to real multiport Stephen Hemminger
2026-02-17 15:05     ` Martin Spinler
2026-02-17 15:22       ` Martin Spinler
2026-02-19  0:12   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260116164436.1649047-2-spinler@cesnet.cz \
    --to=spinler@cesnet.cz \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox