From: Stephen Hemminger <stephen@networkplumber.org>
To: spinler@cesnet.cz
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 4/6] net/nfb: use process private variable for internal data
Date: Mon, 19 Jan 2026 16:13:51 -0800 [thread overview]
Message-ID: <20260119161351.20d06a34@phoenix.local> (raw)
In-Reply-To: <20260116152057.1456380-5-spinler@cesnet.cz>
On Fri, 16 Jan 2026 16:20:55 +0100
spinler@cesnet.cz wrote:
> From: Martin Spinler <spinler@cesnet.cz>
>
> Internal structures of libnfb can't be shared between processes.
> Move these structures from dev_private to process_private, which allows
> secondary process to correctly initialize and uninitialize the eth_dev.
>
> Signed-off-by: Martin Spinler <spinler@cesnet.cz>
> ---
> drivers/net/nfb/nfb.h | 2 +
> drivers/net/nfb/nfb_ethdev.c | 99 +++++++++++++++++++++---------------
> drivers/net/nfb/nfb_rx.c | 2 +-
> drivers/net/nfb/nfb_rxmode.c | 12 ++---
> drivers/net/nfb/nfb_tx.c | 2 +-
> 5 files changed, 67 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/net/nfb/nfb.h b/drivers/net/nfb/nfb.h
> index 917b830283..09d4b7da5f 100644
> --- a/drivers/net/nfb/nfb.h
> +++ b/drivers/net/nfb/nfb.h
> @@ -48,7 +48,9 @@ struct pmd_internals {
> struct nc_rxmac *rxmac[RTE_MAX_NC_RXMAC];
> struct nc_txmac *txmac[RTE_MAX_NC_TXMAC];
> struct nfb_device *nfb;
> +};
>
> +struct pmd_priv {
> uint16_t max_rx_queues;
> uint16_t max_tx_queues;
> };
Where does max_rx_queues get populated in the secondary process?
What if either process calls configure to change number of queues?
Don't see other drivers splitting structure here.
next prev parent reply other threads:[~2026-01-20 0:14 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 14:01 [PATCH 0/6] spinler
2026-01-15 14:01 ` [PATCH 1/6] net/nfb: use constant values for max Rx/Tx queues count spinler
2026-01-15 14:01 ` [PATCH 2/6] net/nfb: fix bad pointer access in queue stats spinler
2026-01-15 14:01 ` [PATCH 3/6] net/nfb: update timestamp calculation to meaningful value spinler
2026-01-15 14:01 ` [PATCH 4/6] net/nfb: use process private variable for internal data spinler
2026-01-15 14:01 ` [PATCH 5/6] net/nfb: release allocated resources correctly spinler
2026-01-15 14:01 ` [PATCH 6/6] net/nfb: stop only started queues in fail path spinler
2026-01-15 14:40 ` [PATCH v2 0/6] net/nfb: code cleanup spinler
2026-01-15 14:40 ` [PATCH v2 1/6] net/nfb: use constant values for max Rx/Tx queues count spinler
2026-01-15 14:40 ` [PATCH v2 2/6] net/nfb: fix bad pointer access in queue stats spinler
2026-01-15 14:40 ` [PATCH v2 3/6] net/nfb: update timestamp calculation to meaningful value spinler
2026-01-15 14:40 ` [PATCH v2 4/6] net/nfb: use process private variable for internal data spinler
2026-01-15 14:40 ` [PATCH v2 5/6] net/nfb: release allocated resources correctly spinler
2026-01-15 14:40 ` [PATCH v2 6/6] net/nfb: stop only started queues in fail path spinler
2026-01-16 5:48 ` [PATCH v2 0/6] net/nfb: code cleanup Stephen Hemminger
2026-01-16 9:42 ` Martin Spinler
2026-01-16 17:39 ` Stephen Hemminger
2026-01-16 15:20 ` spinler
2026-01-16 15:20 ` [PATCH v3 1/6] net/nfb: use constant values for max Rx/Tx queues count spinler
2026-02-02 17:47 ` Stephen Hemminger
2026-02-02 18:58 ` Martin Špinler
2026-01-16 15:20 ` [PATCH v3 2/6] net/nfb: fix bad pointer access in queue stats spinler
2026-01-16 15:20 ` [PATCH v3 3/6] net/nfb: update timestamp calculation to meaningful value spinler
2026-01-16 15:20 ` [PATCH v3 4/6] net/nfb: use process private variable for internal data spinler
2026-01-20 0:13 ` Stephen Hemminger [this message]
2026-01-20 14:13 ` Martin Spinler
2026-01-20 16:11 ` Stephen Hemminger
2026-01-16 15:20 ` [PATCH v3 5/6] net/nfb: release allocated resources correctly spinler
2026-01-20 0:10 ` Stephen Hemminger
2026-01-20 14:14 ` Martin Spinler
2026-01-16 15:20 ` [PATCH v3 6/6] net/nfb: stop only started queues in fail path spinler
2026-01-20 0:09 ` Stephen Hemminger
2026-01-20 14:14 ` Martin Spinler
2026-01-16 15:22 ` [PATCH v3 0/6] net/nfb: code cleanup spinler
2026-01-21 4:57 ` Stephen Hemminger
2026-01-21 17:01 ` [PATCH v4 " spinler
2026-01-21 17:01 ` [PATCH v4 1/6] net/nfb: use constant values for max Rx/Tx queues count spinler
2026-01-21 17:01 ` [PATCH v4 2/6] net/nfb: fix bad pointer access in queue stats spinler
2026-01-21 17:01 ` [PATCH v4 3/6] net/nfb: update timestamp calculation to meaningful value spinler
2026-01-21 17:33 ` Stephen Hemminger
2026-01-27 8:12 ` Martin Spinler
2026-01-27 0:34 ` Stephen Hemminger
2026-01-27 8:16 ` Martin Spinler
2026-01-21 17:01 ` [PATCH v4 4/6] net/nfb: use process private variable for internal data spinler
2026-01-21 17:01 ` [PATCH v4 5/6] net/nfb: release allocated resources correctly spinler
2026-01-21 17:01 ` [PATCH v4 6/6] net/nfb: stop only started queues in fail path spinler
2026-01-21 17:35 ` [PATCH v4 0/6] net/nfb: code cleanup Stephen Hemminger
2026-02-02 19:33 ` [PATCH v5 " spinler
2026-02-02 19:33 ` [PATCH v5 1/6] net/nfb: use constant values for max Rx/Tx queues count spinler
2026-02-02 19:33 ` [PATCH v5 2/6] net/nfb: fix bad pointer access in queue stats spinler
2026-02-10 0:51 ` Stephen Hemminger
2026-02-02 19:33 ` [PATCH v5 3/6] net/nfb: update timestamp calculation to meaningful value spinler
2026-02-02 19:33 ` [PATCH v5 4/6] net/nfb: use process private variable for internal data spinler
2026-02-02 19:33 ` [PATCH v5 5/6] net/nfb: release allocated resources correctly spinler
2026-02-10 0:52 ` Stephen Hemminger
2026-02-02 19:33 ` [PATCH v5 6/6] net/nfb: stop only started queues in fail path spinler
2026-02-03 1:50 ` [PATCH v5 0/6] net/nfb: code cleanup Stephen Hemminger
2026-02-03 6:36 ` Martin Spinler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119161351.20d06a34@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=spinler@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox