Re: [EXTERNAL] [PATCH v6 1/6] common/cnxk: replace variable length state array

Stephen Hemminger
2026-03-02T19:36:32Z

On Mon, 2 Mar 2026 19:06:19 +0000
Tejasree Kondoj <ktejasree@marvell.com> wrote:

> > diff --git a/drivers/common/cnxk/roc_aes.c b/drivers/common/cnxk/roc_aes.c
> > index d84feb546a..babf149ccf 100644
> > --- a/drivers/common/cnxk/roc_aes.c
> > +++ b/drivers/common/cnxk/roc_aes.c
> > @@ -157,9 +157,10 @@ static void
> > cipher(uint8_t *in, uint8_t *out, uint32_t *ks, uint32_t key_rounds, uint8_t
> > in_len)
> > {
> > uint8_t data_word_len = in_len / sizeof(uint32_t);
> > - uint32_t state[data_word_len];
> > + uint32_t state[AES_HASH_KEY_LEN / sizeof(uint32_t)];
> [Tejasree] This line needs to be moved up to maintain reverse xmas tree.

That is a Linux netdev thing, DPDK doesn't care about that.