From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, stable@dpdk.org
Subject: [PATCH v2 3/6] test: fix error handling in ELF load tests
Date: Mon, 19 Jan 2026 17:55:06 -0800 [thread overview]
Message-ID: <20260120015759.301155-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20260120015759.301155-1-stephen@networkplumber.org>
Address related issues found during review
- Add missing TEST_ASSERT for mempool creation in test_bpf_elf_tx_load
- Initialize port variable in test_bpf_elf_rx_load to avoid undefined
behavior in cleanup path if null_vdev_setup fails early
Fixes: cf1e03f881af ("test/bpf: add ELF loading")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/test_bpf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c
index a7d56f8d86..0e969f9f13 100644
--- a/app/test/test_bpf.c
+++ b/app/test/test_bpf.c
@@ -3580,6 +3580,7 @@ test_bpf_elf_tx_load(void)
mb_pool = rte_pktmbuf_pool_create("bpf_tx_test_pool", BPF_TEST_POOLSIZE,
0, 0, RTE_MBUF_DEFAULT_BUF_SIZE,
SOCKET_ID_ANY);
+ TEST_ASSERT(mb_pool != NULL, "failed to create mempool");
ret = null_vdev_setup(null_dev, &port, mb_pool);
if (ret != 0)
@@ -3664,7 +3665,7 @@ test_bpf_elf_rx_load(void)
static const char null_dev[] = "net_null_bpf0";
struct rte_mempool *pool = NULL;
char *tmpfile = NULL;
- uint16_t port;
+ uint16_t port = UINT16_MAX;
int ret;
printf("%s start\n", __func__);
--
2.51.0
next prev parent reply other threads:[~2026-01-20 1:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0260118201223.323024-1-stephen@networkplumber.org>
2026-01-20 1:55 ` [PATCH v2 0/6] fix test failures on larger core systems Stephen Hemminger
2026-01-20 1:55 ` [PATCH v2 1/6] test: add pause to synchronization spinloops Stephen Hemminger
2026-01-21 16:10 ` Bruce Richardson
2026-01-20 1:55 ` [PATCH v2 2/6] test: fix timeout for atomic test on high core count systems Stephen Hemminger
2026-01-21 16:11 ` Bruce Richardson
2026-01-20 1:55 ` Stephen Hemminger [this message]
2026-01-20 12:08 ` [PATCH v2 3/6] test: fix error handling in ELF load tests Marat Khalili
2026-01-20 1:55 ` [PATCH v2 4/6] test: fix unsupported BPF instructions in elf load test Stephen Hemminger
2026-01-21 16:20 ` Bruce Richardson
2026-01-20 1:55 ` [PATCH v2 5/6] test: add file-prefix for all fast-tests on Linux Stephen Hemminger
2026-01-21 16:22 ` Bruce Richardson
2026-01-20 1:55 ` [PATCH v2 6/6] test: fix trace_autotest_with_traces parallel execution Stephen Hemminger
2026-01-21 16:29 ` Bruce Richardson
2026-01-21 16:31 ` [PATCH v2 0/6] fix test failures on larger core systems Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120015759.301155-4-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox