* [PATCH] crypto/ipsec_mb: fix clearing snow3g digest
@ 2026-01-16 11:57 weid wei.dai@picocom.com
0 siblings, 0 replies; 4+ messages in thread
From: weid wei.dai@picocom.com @ 2026-01-16 11:57 UTC (permalink / raw)
To: kai.ji, pablo.de.lara.guarch; +Cc: dev, weid
From: weid <wei.dai@picocom.com>
Before this patch, the software crypto_snow3g
clear the encrypted auth snow3g digest when
the dst mbuf is same as the src mbuf in crypto
op.
This bug can be checked by following way,
start app/dpdk-test --vdev=crypto_snow3g,
run pdcp_autotest
the case failed when i=42 in
run_test_for_one_known_vec() in test_pdcp.c.
The case is PDCP control plane auth snow3g gen
+ cipher snow3g enc.
The case failed because the last 4 bytes are
cleared in last for() loop in line 167 in
process_snow3g_cipher_op() in pmd_snow3g.c .
Fixes: 5208d68d30cb ("crypto/ipsec_mb: support snow3g digest appended
ops")
Signed-off-by: weid <wei.dai@picocom.com>
---
drivers/crypto/ipsec_mb/pmd_snow3g.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c b/drivers/crypto/ipsec_mb/pmd_snow3g.c
index b3c3b05a8a..35fe23c157 100644
--- a/drivers/crypto/ipsec_mb/pmd_snow3g.c
+++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c
@@ -157,7 +157,8 @@ process_snow3g_cipher_op(struct ipsec_mb_qp *qp, struct rte_crypto_op **ops,
for (i = 0; i < num_ops; i++) {
if ((session->op == IPSEC_MB_OP_HASH_VERIFY_THEN_DECRYPT ||
session->op == IPSEC_MB_OP_HASH_GEN_THEN_ENCRYPT) &&
- ops[i]->sym->m_dst != NULL) {
+ ops[i]->sym->m_dst != NULL &&
+ ops[i]->sym->m_dst != ops[i]->sym->m_src) {
digest_appended[i] =
snow3g_digest_appended_in_src(ops[i]);
/* Clear unencrypted digest from
--
2.51.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] crypto/ipsec_mb: fix clearing snow3g digest
@ 2026-01-20 6:12 weid wei.dai@picocom.com
2026-02-10 18:04 ` [EXTERNAL] " Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: weid wei.dai@picocom.com @ 2026-01-20 6:12 UTC (permalink / raw)
To: kai.ji, pablo.de.lara.guarch; +Cc: dev, weid
From: weid <wei.dai@picocom.com>
Before this patch, the software crypto_snow3g
clear the encrypted auth snow3g digest when
the dst mbuf is same as the src mbuf in crypto
op.
This bug can be checked by following way,
start app/dpdk-test --vdev=crypto_snow3g,
run pdcp_autotest
the case failed when i=42 in
run_test_for_one_known_vec() in test_pdcp.c.
The case is PDCP control plane auth snow3g gen
+ cipher snow3g enc.
The case failed because the last 4 bytes are
cleared in last for() loop in line 167 in
process_snow3g_cipher_op() in pmd_snow3g.c .
Fixes: 5208d68d30cb ("crypto/ipsec_mb: support snow3g digest appended ops")
Signed-off-by: weid <wei.dai@picocom.com>
---
drivers/crypto/ipsec_mb/pmd_snow3g.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c b/drivers/crypto/ipsec_mb/pmd_snow3g.c
index b3c3b05a8a..35fe23c157 100644
--- a/drivers/crypto/ipsec_mb/pmd_snow3g.c
+++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c
@@ -157,7 +157,8 @@ process_snow3g_cipher_op(struct ipsec_mb_qp *qp, struct rte_crypto_op **ops,
for (i = 0; i < num_ops; i++) {
if ((session->op == IPSEC_MB_OP_HASH_VERIFY_THEN_DECRYPT ||
session->op == IPSEC_MB_OP_HASH_GEN_THEN_ENCRYPT) &&
- ops[i]->sym->m_dst != NULL) {
+ ops[i]->sym->m_dst != NULL &&
+ ops[i]->sym->m_dst != ops[i]->sym->m_src) {
digest_appended[i] =
snow3g_digest_appended_in_src(ops[i]);
/* Clear unencrypted digest from
--
2.51.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [EXTERNAL] [PATCH] crypto/ipsec_mb: fix clearing snow3g digest
2026-01-20 6:12 [PATCH] crypto/ipsec_mb: fix clearing snow3g digest weid wei.dai@picocom.com
@ 2026-02-10 18:04 ` Akhil Goyal
2026-03-10 6:05 ` Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2026-02-10 18:04 UTC (permalink / raw)
To: kai.ji@intel.com, pablo.de.lara.guarch@intel.com
Cc: dev@dpdk.org, weid wei.dai@picocom.com
Hi Pablo/Kai,
Please ack if no objection
> From: weid <wei.dai@picocom.com>
>
> Before this patch, the software crypto_snow3g
> clear the encrypted auth snow3g digest when
> the dst mbuf is same as the src mbuf in crypto
> op.
>
> This bug can be checked by following way,
> start app/dpdk-test --vdev=crypto_snow3g,
> run pdcp_autotest
> the case failed when i=42 in
> run_test_for_one_known_vec() in test_pdcp.c.
> The case is PDCP control plane auth snow3g gen
> + cipher snow3g enc.
> The case failed because the last 4 bytes are
> cleared in last for() loop in line 167 in
> process_snow3g_cipher_op() in pmd_snow3g.c .
>
> Fixes: 5208d68d30cb ("crypto/ipsec_mb: support snow3g digest appended ops")
>
> Signed-off-by: weid <wei.dai@picocom.com>
> ---
> drivers/crypto/ipsec_mb/pmd_snow3g.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c
> b/drivers/crypto/ipsec_mb/pmd_snow3g.c
> index b3c3b05a8a..35fe23c157 100644
> --- a/drivers/crypto/ipsec_mb/pmd_snow3g.c
> +++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c
> @@ -157,7 +157,8 @@ process_snow3g_cipher_op(struct ipsec_mb_qp *qp,
> struct rte_crypto_op **ops,
> for (i = 0; i < num_ops; i++) {
> if ((session->op ==
> IPSEC_MB_OP_HASH_VERIFY_THEN_DECRYPT ||
> session->op ==
> IPSEC_MB_OP_HASH_GEN_THEN_ENCRYPT) &&
> - ops[i]->sym->m_dst != NULL) {
> + ops[i]->sym->m_dst != NULL &&
> + ops[i]->sym->m_dst != ops[i]->sym->m_src) {
> digest_appended[i] =
> snow3g_digest_appended_in_src(ops[i]);
> /* Clear unencrypted digest from
> --
> 2.51.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXTERNAL] [PATCH] crypto/ipsec_mb: fix clearing snow3g digest
2026-02-10 18:04 ` [EXTERNAL] " Akhil Goyal
@ 2026-03-10 6:05 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2026-03-10 6:05 UTC (permalink / raw)
To: Akhil Goyal, kai.ji@intel.com, pablo.de.lara.guarch@intel.com
Cc: dev@dpdk.org, weid wei.dai@picocom.com
> Hi Pablo/Kai,
> Please ack if no objection
>
Reminder for ack.
>
> > From: weid <wei.dai@picocom.com>
> >
> > Before this patch, the software crypto_snow3g
> > clear the encrypted auth snow3g digest when
> > the dst mbuf is same as the src mbuf in crypto
> > op.
> >
> > This bug can be checked by following way,
> > start app/dpdk-test --vdev=crypto_snow3g,
> > run pdcp_autotest
> > the case failed when i=42 in
> > run_test_for_one_known_vec() in test_pdcp.c.
> > The case is PDCP control plane auth snow3g gen
> > + cipher snow3g enc.
> > The case failed because the last 4 bytes are
> > cleared in last for() loop in line 167 in
> > process_snow3g_cipher_op() in pmd_snow3g.c .
> >
> > Fixes: 5208d68d30cb ("crypto/ipsec_mb: support snow3g digest appended
> ops")
> >
> > Signed-off-by: weid <wei.dai@picocom.com>
> > ---
> > drivers/crypto/ipsec_mb/pmd_snow3g.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c
> > b/drivers/crypto/ipsec_mb/pmd_snow3g.c
> > index b3c3b05a8a..35fe23c157 100644
> > --- a/drivers/crypto/ipsec_mb/pmd_snow3g.c
> > +++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c
> > @@ -157,7 +157,8 @@ process_snow3g_cipher_op(struct ipsec_mb_qp *qp,
> > struct rte_crypto_op **ops,
> > for (i = 0; i < num_ops; i++) {
> > if ((session->op ==
> > IPSEC_MB_OP_HASH_VERIFY_THEN_DECRYPT ||
> > session->op ==
> > IPSEC_MB_OP_HASH_GEN_THEN_ENCRYPT) &&
> > - ops[i]->sym->m_dst != NULL) {
> > + ops[i]->sym->m_dst != NULL &&
> > + ops[i]->sym->m_dst != ops[i]->sym->m_src) {
> > digest_appended[i] =
> > snow3g_digest_appended_in_src(ops[i]);
> > /* Clear unencrypted digest from
> > --
> > 2.51.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-10 6:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-20 6:12 [PATCH] crypto/ipsec_mb: fix clearing snow3g digest weid wei.dai@picocom.com
2026-02-10 18:04 ` [EXTERNAL] " Akhil Goyal
2026-03-10 6:05 ` Akhil Goyal
-- strict thread matches above, loose matches on Subject: below --
2026-01-16 11:57 weid wei.dai@picocom.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox