Re: [PATCH v3 3/4] net/intel: add support for Precision Time Protocol

Bruce Richardson
2025-12-16T12:43:32Z

On Mon, Nov 03, 2025 at 11:06:44AM -0500, Soumyadeep Hore wrote:
> Add support for PTP that contains negotiation with CP to receive a
> set of supported functionalities through capabilities,
> get/set/adjust the time of the main timer and Tx timestamping
> through secondary mailbox dedicated to PTP.
>
> Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
> ---
> drivers/net/intel/common/tx.h | 1 +
> drivers/net/intel/idpf/idpf_common_rxtx.c | 186 +++++++++------
> drivers/net/intel/idpf/idpf_common_rxtx.h | 10 +
> drivers/net/intel/idpf/idpf_ethdev.c | 275 ++++++++++++++++++++++
> 4 files changed, 401 insertions(+), 71 deletions(-)
>
> diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
> index 5af64a4cfe..fe175f7d65 100644
> --- a/drivers/net/intel/common/tx.h
> +++ b/drivers/net/intel/common/tx.h
> @@ -113,6 +113,7 @@ struct ci_tx_queue {
> uint16_t sw_tail;
> uint16_t rs_compl_count;
> uint8_t expected_gen_id;
> + uint32_t latch_idx; /* Tx timestamp latch index */

This creates padding in the structure. Unless there is a good reason why
not, generally structure variables should be kept in order of size, from
biggest to smallest to avoid padding.

/Bruce