public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Lukas Sismis <sismis@dyna-nic.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4 0/7] flow_parser: add shared parser library
Date: Tue, 20 Jan 2026 17:00:00 -0800	[thread overview]
Message-ID: <20260120170000.7823a453@phoenix.local> (raw)
In-Reply-To: <20260120232424.195059-1-sismis@dyna-nic.com>

On Wed, 21 Jan 2026 00:24:17 +0100
Lukas Sismis <sismis@dyna-nic.com> wrote:

> External applications like Suricata IDS [1] need to express hardware filtering
> rules in a consistent, human-readable format. Rather than inventing custom
> syntax, reusing testpmd's well-tested flow grammar provides immediate
> compatibility with existing documentation and user knowledge.
> 
> Note: This library provides only one way to create rte_flow structures.
> Applications can also construct rte_flow_attr, rte_flow_item[], and
> rte_flow_action[] directly in C code.
> 
> Design
> ------
> The library (librte_flow_parser) exposes the following APIs:
> - rte_flow_parser_parse_attr_str(): Parse attributes only
> - rte_flow_parser_parse_pattern_str(): Parse patterns only
> - rte_flow_parser_parse_actions_str(): Parse actions only
> 
> Testpmd is updated to use the library, ensuring a single
> maintained parser implementation.
> 
> Testing and Demo
> -------
> - Functional tests in dpdk-test
> - Example application: examples/flow_parsing
> 
> Changes
> -------
> 
> v4:
> - ethdev changes in separate commit
> - library's public API only exposes attribute, pattern and action parsing,
>   while the full command parsing is kept internal for testpmd usage only.
> - Addressed Stephen's comments from V3
> - dpdk-test now have tests focused on public and internal library functions
> 
> v3:
> - Add more functional tests
> - More concise MAINTAINERS updates
> - Updated license headers
> - A thing to note: When playing with flow commands, I figured, some may use
>   non-flow commands, such as raw decap/encap, policy meter and others.
>   Flow parser library itself now supports `set` command to set e.g. the decap/
>   encap parameters, as the flow syntax only supports defining the index of the
>   encap/decap configs. The library, however, does not support e.g. `create`
>   command to create policy meters, as that is just an ID and it can be created
>   separately using rte_meter APIs.
> 
> [1] https://github.com/OISF/suricata/pull/13950
> 

There seem to be  lot of build failures in CI for this version.

  parent reply	other threads:[~2026-01-21  1:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 23:24 [PATCH v4 0/7] flow_parser: add shared parser library Lukas Sismis
2026-01-20 23:24 ` [PATCH v4 1/7] cmdline: include stddef.h for offsetof Lukas Sismis
2026-01-20 23:24 ` [PATCH v4 2/7] ethdev: add RSS type helper APIs Lukas Sismis
2026-01-20 23:24 ` [PATCH v4 4/7] app/testpmd: use shared flow parser library Lukas Sismis
2026-01-20 23:24 ` [PATCH v4 5/7] examples/flow_parsing: add flow parser demo Lukas Sismis
2026-01-20 23:24 ` [PATCH v4 6/7] dpdk-test: add flow parser library functional tests Lukas Sismis
2026-01-20 23:24 ` [PATCH v4 7/7] mailmap: update a new contributor email Lukas Sismis
2026-01-21  1:00 ` Stephen Hemminger [this message]
2026-01-21  4:55 ` [PATCH v4 0/7] flow_parser: add shared parser library Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260120170000.7823a453@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=sismis@dyna-nic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox