From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5EEC44508 for ; Wed, 21 Jan 2026 17:02:43 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E817742E0C; Wed, 21 Jan 2026 18:02:05 +0100 (CET) Received: from office2.cesnet.cz (office2.cesnet.cz [78.128.248.237]) by mails.dpdk.org (Postfix) with ESMTP id A5E9940261; Wed, 21 Jan 2026 18:01:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2-2020; t=1769014918; bh=mVt7TgdcigCRP30DlP5naU5h/wOBpV83CCuw6ymeDeI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AKXO9fV8j6SC38CApQb7GC/beS5Fb4XTnBR5bYKQHVnrJN6FdIy9phZCbid4EI40H zpFb2+IG96Tgy28h4KePaMQ6aTakCcs9eRtvyekatzdTVr4eVLBD9bNyIaNY8ZodoM 0g0Ek/zYQPnhpi2reCt/VUWsGof4KaUkqtXNHVQLJX3ixOp4vmn5O9zLwdWY5DA3AW qP+H0qa/PQAuEzPtqTkOs1toW7dd/eA3zIfrmYQYowChyBZ0PrwLfShbE9pSmLh5mO KNMAp6yzwrcs1VnI2o+aAHWqu8VS1r8puU76LyUmJBAcjdVKwdC0LLAnOgMRunvgtK P7ozRgHiAj8YQ== Received: from emil.cesnet.cz (gtx107.cesnet.cz [IPv6:2001:718:812:27::107]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 846C3118007E; Wed, 21 Jan 2026 18:01:58 +0100 (CET) From: spinler@cesnet.cz To: dev@dpdk.org Cc: Martin Spinler , stable@dpdk.org Subject: [PATCH v4 6/6] net/nfb: stop only started queues in fail path Date: Wed, 21 Jan 2026 18:01:20 +0100 Message-ID: <20260121170120.268553-7-spinler@cesnet.cz> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260121170120.268553-1-spinler@cesnet.cz> References: <20260115140134.235877-1-spinler@cesnet.cz> <20260121170120.268553-1-spinler@cesnet.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Martin Spinler The driver should stop only running queues in case of error inside eth_dev_start. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Cc: stable@dpdk.org Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_ethdev.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c index abc5c12b1e..947ee9e21d 100644 --- a/drivers/net/nfb/nfb_ethdev.c +++ b/drivers/net/nfb/nfb_ethdev.c @@ -139,11 +139,12 @@ nfb_eth_dev_start(struct rte_eth_dev *dev) return 0; err_tx: - for (i = 0; i < nb_tx; i++) - nfb_eth_tx_queue_stop(dev, i); + for (; i > 0; i--) + nfb_eth_tx_queue_stop(dev, i - 1); + i = nb_rx; err_rx: - for (i = 0; i < nb_rx; i++) - nfb_eth_rx_queue_stop(dev, i); + for (; i > 0; i--) + nfb_eth_rx_queue_stop(dev, i - 1); return ret; } -- 2.52.0