Re: [PATCH v17 2/2] eal: RTE_PTR_ADD/SUB API improvements

Scott Mitchell
2026-02-03T16:24:31Z

> Again, thank you for all the work you put into this, Scott!

Thanks for all the feedback :)

> > 2. integer types that represent pointers
>
> Please get rid of all the RTE_INT_PTR macros.
> IMO, these macros look too much like plain wrappers around simple +/- operators.
> It seems they are only needed for the cnxk drivers; those drivers can probably be fixed in some other way.
>

Sounds good. Looking at the current state, cnxk doesn't even need
them. Just 1 usage in eal_common_options.c I can cast and work around.

> > + RTE_ASSERT(mi);
>
> Preferred: RTE_ASSERT(mi != NULL);

Asserts updated