Re: [PATCH v1 0/4] improve NBL memory safety and mailbox reliability

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 22 Jan 2026 19:16:23 -0800
Dimon Zhao <dimon.zhao@nebula-matrix.com> wrote:

> Includes fixes for mbuf/memzone leaks and mailbox state handling.
> 
> Dimon Zhao (4):
>   net/nbl: fix memzone leak in queue release
>   net/nbl: optimize mbuf headroom usage in packet transmission
>   net/nbl: fix mbuf double-free in queue cleanup
>   net/nbl: improve exception handling for the mailbox
> 
>  drivers/net/nbl/nbl_dev/nbl_dev.c     |   2 +-
>  drivers/net/nbl/nbl_hw/nbl_channel.c  |  94 ++++++++++++++++----
>  drivers/net/nbl/nbl_hw/nbl_channel.h  |  11 ++-
>  drivers/net/nbl/nbl_hw/nbl_resource.h |   2 +
>  drivers/net/nbl/nbl_hw/nbl_txrx.c     | 122 +++++++++++++++++++-------
>  drivers/net/nbl/nbl_hw/nbl_txrx_ops.h |   2 +-
>  6 files changed, 179 insertions(+), 54 deletions(-)
> 

Some of the automated review comments are valid, some are not.
Please resubmit, or I can fix during merge

Fix:
1. Remove unnecessary NULL checks before `rte_free()` and `rte_memzone_free()`
4. Fix grammar in log message ("does not" instead of "do not")

Ok as is, but would be good to change:
2. Add blank lines between variable declarations and statements
5. Use "Tx" instead of "transmission" in commit subject

Ignore:
3. Use explicit NULL comparisons (`!= NULL`) instead of implicit boolean tests