From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/2] eal: add location info to interrupt error message
Date: Mon, 26 Jan 2026 10:16:31 -0800 [thread overview]
Message-ID: <20260126101631.144de68e@phoenix.local> (raw)
In-Reply-To: <20260126164519.3029952-1-bruce.richardson@intel.com>
On Mon, 26 Jan 2026 16:45:18 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> The error message about the interrupt being unallocated is called from
> multiple positions, so if seen in the logs the user cannot tell which
> function is actually generating the message. Add function name and line
> number info to the message to clarify things.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/eal/common/eal_common_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/common/eal_common_interrupts.c b/lib/eal/common/eal_common_interrupts.c
> index b42fa862f3..a2a310750a 100644
> --- a/lib/eal/common/eal_common_interrupts.c
> +++ b/lib/eal/common/eal_common_interrupts.c
> @@ -17,7 +17,7 @@
> /* Macros to check for valid interrupt handle */
> #define CHECK_VALID_INTR_HANDLE(intr_handle) do { \
> if (intr_handle == NULL) { \
> - EAL_LOG(DEBUG, "Interrupt instance unallocated"); \
> + EAL_LOG(DEBUG, "%s, ln %d: Interrupt instance unallocated", __func__, __LINE__); \
Using "ln %d" seems different from other places. Maybe
EAL_LOG(DEBUG, "%s:%d Interrupt instance unallocated", __FILE__, __LINE__); \
next prev parent reply other threads:[~2026-01-26 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 16:45 [PATCH 1/2] eal: add location info to interrupt error message Bruce Richardson
2026-01-26 16:45 ` [PATCH 2/2] test/eal_flags: add EAL debug logs to recursive calls Bruce Richardson
2026-02-03 14:17 ` David Marchand
2026-02-03 15:39 ` Bruce Richardson
2026-01-26 18:16 ` Stephen Hemminger [this message]
2026-02-13 15:22 ` [PATCH v2 0/3] improve error reporting & resilience in unit tests Bruce Richardson
2026-02-13 15:22 ` [PATCH v2 1/3] eal: add location info to interrupt error message Bruce Richardson
2026-02-13 15:22 ` [PATCH v2 2/3] test/eal_flags: add EAL debug flags to recursive calls Bruce Richardson
2026-02-13 15:22 ` [PATCH v2 3/3] test/eal_flags: remove PCI probing for " Bruce Richardson
2026-02-16 14:48 ` [PATCH v2 0/3] improve error reporting & resilience in unit tests David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126101631.144de68e@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox