Re: [PATCH v8 0/8] pcapng: fixes and improvements

Thomas Monjalon
2026-02-17T16:39:59Z

16/02/2026 22:37, Stephen Hemminger:
> Fix string handling in the pcapng library and improve test coverage.
>
> The pcapng format uses 16-bit length fields for option data, but the
> library did not validate input lengths and used fixed-size stack
> buffers that could overflow with large strings.
>
> Patches 1-4 add string validation, dynamic allocation, and return
> value documentation. Existing return value conventions are preserved
> to avoid an ABI break.
>
> Patch 5 chains an additional mbuf segment when a comment exceeds
> tailroom instead of dropping the packet.
>
> Patch 6 replaces per-packet timestamp divisions with a precomputed
> reciprocal multiply-shift.
>
> Patches 7-8 improve test coverage and fix the build dependency on
> the null PMD.

Applied, thanks.