Re: [PATCH v4 4/4] net/af_packet: add software checksum offload support

Scott Mitchell
2026-02-03T06:42:13Z

> This is getting a little large to be inline.
> Maybe split into inline that checks offload flags, and non-inline
> that does the checksum if necessary.

I'll move implementation into rte_net.c for now to avoid exposing
additional surface area in .h.

>
> The code could use rte_pktmbuf_linearize() if necessary.
>
>
> There is code duplication in multiple arms of the if statement
> Can the code just "do the right thing" based on the mbufs it is given.
> If the mbuf is indirect or has ref count > 1 then copy headers, otherwise
> do in place.

Sounds good.