Re: [REVIEW] net/af_packet: software checksum

Scott Mitchell
2026-02-02T07:55:35Z

Will resolve comments in v4.

Also I've noticed the AI feedback often has paragraphs that end with
"this is fine". Is there any way to suppress those as they take time
to read/parse/understand?

> ## Patch 3/4: net/af_packet: tx poll control
> **Warning: Uninitialized struct pollfd when txpollnotrdy is false**
> ```c
> if (pkt_q->txpollnotrdy) {
> memset(&pfd, 0, sizeof(pfd));
> ...
> }
> ```
> If `txpollnotrdy` is false, `pfd` is uninitialized but referenced later in the `poll()` call. This is a potential bug - the poll path won't be taken when `txpollnotrdy` is false, but the compiler may still warn.

False positive. pfd is never used if pkt_q->txpollnotrdy is false (the
conditions below short circuits.