public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [REVIEW] common/mlx5: support dmabuf
Date: Wed, 28 Jan 2026 09:43:50 -0800	[thread overview]
Message-ID: <20260128094350.1224b08c@phoenix.local> (raw)
In-Reply-To: <CAJFAV8zWtmZX86h7U=tXxAss+1B7=Jpex9NgNkOA67ATTWyvNQ@mail.gmail.com>

On Wed, 28 Jan 2026 15:30:17 +0100
David Marchand <david.marchand@redhat.com> wrote:

> Hello Stephen,
> 
> On Tue, 27 Jan 2026 at 20:22, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > AI-generated review of bundle-1701-dmabuf.mbox
> > Reviewed using Claude (claude-opus-4-5-20251101)
> >
> > This is an automated review. Please verify all suggestions.
> >
> > ---
> >
> > # DPDK Patch Review: dmabuf Support
> >
> > ## Summary
> > This patch series adds dmabuf (DMA buffer) support to DPDK EAL and the MLX5 driver, enabling DMA transfers between drivers without proprietary kernel modules.
> >  
> [snip]
> 
> > **Warning: Missing version.map updates**
> > New exported symbols need to be added to `lib/eal/version.map` under the `EXPERIMENTAL` section.  
> 
> I noticed similar comments on other series.
> There is no version.map update needed anymore, since v25.07.
> 
> 

I got AI to fix itself :-)

Now I understand the issue. The AGENTS.md says "New external functions must be exported properly" but doesn't explain the current mechanism. The AI is filling in with outdated knowledge about version.map files.

DPDK has moved to automatic symbol map generation using export macros. 

  parent reply	other threads:[~2026-01-28 17:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 17:44 [PATCH 0/2] support dmabuf Cliff Burdick
2026-01-27 17:44 ` [PATCH 1/2] eal: " Cliff Burdick
2026-01-29  1:48   ` Stephen Hemminger
2026-01-29  1:51   ` Stephen Hemminger
2026-01-27 17:44 ` [PATCH 2/2] common/mlx5: " Cliff Burdick
2026-01-27 19:21   ` [REVIEW] " Stephen Hemminger
2026-01-28 14:30     ` David Marchand
2026-01-28 17:10       ` Stephen Hemminger
2026-01-28 17:43       ` Stephen Hemminger [this message]
2026-02-03 17:34     ` Cliff Burdick
2026-01-29  1:51   ` [PATCH 2/2] " Stephen Hemminger
2026-01-28  0:04 ` [PATCH 0/2] " Stephen Hemminger
2026-02-03 17:18   ` Cliff Burdick
2026-02-03 22:26 ` [PATCH v2 " Cliff Burdick
2026-02-03 22:26   ` [PATCH v2 1/2] eal: " Cliff Burdick
2026-02-03 22:26   ` [PATCH v2 2/2] common/mlx5: " Cliff Burdick
2026-02-03 23:02   ` [PATCH v3 0/2] " Cliff Burdick
2026-02-03 23:02     ` [PATCH v3 1/2] eal: " Cliff Burdick
2026-02-03 23:02     ` [PATCH v3 2/2] common/mlx5: " Cliff Burdick
2026-02-04 15:50     ` [PATCH v4 0/2] " Cliff Burdick
2026-02-04 15:50       ` [PATCH v4 1/2] eal: " Cliff Burdick
2026-02-12 13:57         ` Burakov, Anatoly
2026-02-04 15:50       ` [PATCH v4 2/2] common/mlx5: " Cliff Burdick
2026-02-05 18:48       ` [PATCH v4 0/2] " Stephen Hemminger
2026-02-05 20:25         ` Cliff Burdick
2026-02-05 22:50           ` Stephen Hemminger
2026-03-31  3:15       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128094350.1224b08c@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox