public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: ciara.loftus@intel.com, Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] net/ice: ensure correct vector flag after reconfiguration
Date: Wed, 28 Jan 2026 11:41:10 +0000	[thread overview]
Message-ID: <20260128114110.39253-1-bruce.richardson@intel.com> (raw)

After configuring the Tx path to be used, the ice driver sets the
tx_vec_allowed flag if a vector path is chosen. However, on
reconfiguration, the flag is not cleared if a scalar path is chosen,
leading to crashes on driver shutdown as the wrong cleanup function
would be used in that case. Fix issue, by always setting the flag to
true or false explicitly.

Fixes: d3206e40c435 ("net/ice: use common Tx path selection infrastructure")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/intel/ice/ice_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
index 59ff4c31c8..816733819f 100644
--- a/drivers/net/intel/ice/ice_rxtx.c
+++ b/drivers/net/intel/ice/ice_rxtx.c
@@ -3721,8 +3721,8 @@ ice_set_tx_function(struct rte_eth_dev *dev)
 						ICE_TX_DEFAULT);
 
 out:
-	if (ice_tx_path_infos[ad->tx_func_type].features.simd_width >= RTE_VECT_SIMD_256)
-		ad->tx_vec_allowed = true;
+	ad->tx_vec_allowed =
+		(ice_tx_path_infos[ad->tx_func_type].features.simd_width >= RTE_VECT_SIMD_256);
 
 	dev->tx_pkt_burst = mbuf_check ? ice_xmit_pkts_check :
 					 ice_tx_path_infos[ad->tx_func_type].pkt_burst;
-- 
2.51.0


             reply	other threads:[~2026-01-28 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 11:41 Bruce Richardson [this message]
2026-01-29  9:42 ` [PATCH] net/ice: ensure correct vector flag after reconfiguration Loftus, Ciara
2026-01-29 11:56   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128114110.39253-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox