From: Stephen Hemminger <stephen@networkplumber.org>
To: Cliff Burdick <cburdick@nvidia.com>
Cc: <dev@dpdk.org>, <anatoly.burakov@intel.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Subject: Re: [PATCH 2/2] common/mlx5: support dmabuf
Date: Wed, 28 Jan 2026 17:51:57 -0800 [thread overview]
Message-ID: <20260128175157.15169b10@phoenix.local> (raw)
In-Reply-To: <20260127174429.1504288-3-cburdick@nvidia.com>
On Tue, 27 Jan 2026 17:44:09 +0000
Cliff Burdick <cburdick@nvidia.com> wrote:
> +static struct ibv_mr *
> +mlx5_glue_reg_dmabuf_mr(struct ibv_pd *pd, uint64_t offset, size_t length,
> + uint64_t iova, int fd, int access)
> +{
> +#ifdef HAVE_IBV_REG_DMABUF_MR
> + return ibv_reg_dmabuf_mr(pd, offset, length, iova, fd, access);
> +#else
> + (void)pd;
> + (void)offset;
> + (void)length;
> + (void)iova;
> + (void)fd;
> + (void)access;
> + errno = ENOTSUP;
> + return NULL;
> +#endif
> +}
I would prefer the callback hook did not exist (was NULL)
if you don't have your #ifdef.
The (void) change looks messy and better handled by caller.
next prev parent reply other threads:[~2026-01-29 1:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 17:44 [PATCH 0/2] support dmabuf Cliff Burdick
2026-01-27 17:44 ` [PATCH 1/2] eal: " Cliff Burdick
2026-01-29 1:48 ` Stephen Hemminger
2026-01-29 1:51 ` Stephen Hemminger
2026-01-27 17:44 ` [PATCH 2/2] common/mlx5: " Cliff Burdick
2026-01-27 19:21 ` [REVIEW] " Stephen Hemminger
2026-01-28 14:30 ` David Marchand
2026-01-28 17:10 ` Stephen Hemminger
2026-01-28 17:43 ` Stephen Hemminger
2026-02-03 17:34 ` Cliff Burdick
2026-01-29 1:51 ` Stephen Hemminger [this message]
2026-01-28 0:04 ` [PATCH 0/2] " Stephen Hemminger
2026-02-03 17:18 ` Cliff Burdick
2026-02-03 22:26 ` [PATCH v2 " Cliff Burdick
2026-02-03 22:26 ` [PATCH v2 1/2] eal: " Cliff Burdick
2026-02-03 22:26 ` [PATCH v2 2/2] common/mlx5: " Cliff Burdick
2026-02-03 23:02 ` [PATCH v3 0/2] " Cliff Burdick
2026-02-03 23:02 ` [PATCH v3 1/2] eal: " Cliff Burdick
2026-02-03 23:02 ` [PATCH v3 2/2] common/mlx5: " Cliff Burdick
2026-02-04 15:50 ` [PATCH v4 0/2] " Cliff Burdick
2026-02-04 15:50 ` [PATCH v4 1/2] eal: " Cliff Burdick
2026-02-12 13:57 ` Burakov, Anatoly
2026-02-04 15:50 ` [PATCH v4 2/2] common/mlx5: " Cliff Burdick
2026-02-05 18:48 ` [PATCH v4 0/2] " Stephen Hemminger
2026-02-05 20:25 ` Cliff Burdick
2026-02-05 22:50 ` Stephen Hemminger
2026-03-31 3:15 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128175157.15169b10@phoenix.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=bingz@nvidia.com \
--cc=cburdick@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox