From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8DAD46C16 for ; Thu, 29 Jan 2026 01:44:29 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C78540650; Thu, 29 Jan 2026 02:43:47 +0100 (CET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 6E06D40A7D for ; Thu, 29 Jan 2026 02:43:43 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so4264635e9.1 for ; Wed, 28 Jan 2026 17:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1769651023; x=1770255823; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o5DR+9CfjZwkjmxCYZ/r4n1qhe1Pf6hGuP8uMq73qeU=; b=ZqGjHUhiGkhN+xliwnzjN7r3/T/j79npE/1QWbnjO77RUfa/68WL/4re90N5HzOW4o JveSjN0y6cLFHlNZLfwMTqZHLf3FujtMLrCdMIdzcvvg8glb5L0Yh5J/dSSsIVxAoFiB ZeTP7RHRsq/JMDAFhaNy0UcwiJmjCb6/De/nea3PsdNMVf2MOa5hwudIiZ3v+k64RqKV 9Ar5LBlTevZBIrR9ctYGU5PqzuVTht71AGIVPqsrL4TGd45rAkAsX0NEvySzqPugSFJ/ 4U1jiJlEnsEM+pGH+CrFrML2TJYwysg05x7znuG+0E3R9QrYQTSHAydS4UKI8c5XOWat 0f1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769651023; x=1770255823; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o5DR+9CfjZwkjmxCYZ/r4n1qhe1Pf6hGuP8uMq73qeU=; b=NLoSpeKuRGOo9E5/lTcYrHWOqB8iAx3sTFO3QzNXkgBOnucbQdffJKtlsbJxnwFcCi /YOBwaPbxGe69dnWKDuL3MQy3XOlLK8FDI/GJgAlJB5baUqR9T6+AI1dSGbCdsVoQuJQ xWRHNtT/fs3ddsjQpNuYq/qbXx8KaArOksxVYztkagyprOY6lGrBHvsXf3OaSvNxKO8B iMf2Jvp+ZFpgbWLiqp9dOG1KhuFWXQsAaQMvAtPAXY09X9/NhWmrGIklV/Q/sJY1CPQ8 kFVPwboB9p7sWS/RcetDirb1pili/5Flh78c5O4uhoymH7dcE149QDjzaVGU0ijYUz4a U6+g== X-Gm-Message-State: AOJu0YzrvLRq+7qrcOuN2dBOtQFokH8NvXXySpAwjujjL3LFLTlsF+5D M6T6XfluheZJ1Gjk2PwHFd/oQ0pOzQu1yPMHRLvFnYxxACjkiU2ffCH4TVEV+JW0IyGgNm8lhbs BDNwq X-Gm-Gg: AZuq6aKYAJXU/qNJodcQDSZsqQaSK/QL7vCEyBXTPkDixWxrC7J8ibPGCVEvXU4asNc 1Q646ZSJFmmsXgdJyL6SENLc0tH3nXKLRJOKDWPN0emg/CD9eGiBWQfv1sROE849bWhqdCh2Bxi fINrijwNWDvPUuUQTXhzG1vOp4RFh98ML7Rw0z9Dz63zYDfHBkIYT77tL5c1BJ1ZsisnotqyFTW 1BJAzBE0orSrgtdmQKxZsJIdgJAnz48KqTJ1QHwmvzPXybbyOuRo/ApIjZJ76liNHK44UHyW2bc n0xZ2X3RWDe1Vy0u/URtZswR8g8nzw5mdpxX2TJxK9O8mC4aCkyCKeZjVs9/tQHVZLIVgvGKdI4 c+4oxoNidCvok+Mx5qYBROmeP3GzwFrN725/ylM7hTeEDYJXsZQWF1iF7f8sgYEeiOFCBFpeYwE z7gZXPV42pNo7McgAiyui1cgEAi73jwcLOP6j8x0C30SoWUuXt3A== X-Received: by 2002:a05:600c:5395:b0:477:c478:46d7 with SMTP id 5b1f17b1804b1-48069c55751mr88789945e9.22.1769651023062; Wed, 28 Jan 2026 17:43:43 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-481a5e18427sm3217985e9.16.2026.01.28.17.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 17:43:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anatoly Burakov Subject: [PATCH v14 11/17] eal: check for hugefile path overflow Date: Wed, 28 Jan 2026 17:41:14 -0800 Message-ID: <20260129014313.939831-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260129014313.939831-1-stephen@networkplumber.org> References: <20251202172626.283094-1-stephen@networkplumber.org> <20260129014313.939831-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When constructing huge filename path, check for possible overflow of PATH_MAX. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_filesystem.h | 10 +++++---- lib/eal/linux/eal_hugepage_info.c | 34 +++++++++++++++++++++---------- lib/eal/linux/eal_memalloc.c | 11 ++++++++-- lib/eal/linux/eal_memory.c | 9 ++++++-- 4 files changed, 45 insertions(+), 19 deletions(-) diff --git a/lib/eal/common/eal_filesystem.h b/lib/eal/common/eal_filesystem.h index 70ae21b078..c2f2856e27 100644 --- a/lib/eal/common/eal_filesystem.h +++ b/lib/eal/common/eal_filesystem.h @@ -104,12 +104,14 @@ eal_hugepage_data_path(void) /** String format for hugepage map files. */ #define HUGEFILE_FMT "%s/%smap_%d" -static inline const char * +static inline __rte_warn_unused_result const char * eal_get_hugefile_path(char *buffer, size_t buflen, const char *hugedir, int f_id) { - snprintf(buffer, buflen, HUGEFILE_FMT, hugedir, - eal_get_hugefile_prefix(), f_id); - return buffer; + if (snprintf(buffer, buflen, HUGEFILE_FMT, hugedir, + eal_get_hugefile_prefix(), f_id) >= (int)buflen) + return NULL; + else + return buffer; } /** define the default filename prefix for the %s values above */ diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index f3ee474735..2edcb25252 100644 --- a/lib/eal/linux/eal_hugepage_info.c +++ b/lib/eal/linux/eal_hugepage_info.c @@ -70,11 +70,14 @@ create_shared_memory(const char *filename, const size_t mem_size) static int get_hp_sysfs_value(const char *subdir, const char *file, unsigned long *val) { - char path[PATH_MAX]; + char *path = NULL; + int ret; - snprintf(path, sizeof(path), "%s/%s/%s", - sys_dir_path, subdir, file); - return eal_parse_sysfs_value(path, val); + if (asprintf(&path, "%s/%s/%s", sys_dir_path, subdir, file) < 0) + return -1; + ret = eal_parse_sysfs_value(path, val); + free(path); + return ret; } /* this function is only called from eal_hugepage_info_init which itself @@ -135,13 +138,15 @@ get_num_hugepages(const char *subdir, size_t sz, unsigned int reusable_pages) static uint32_t get_num_hugepages_on_node(const char *subdir, unsigned int socket, size_t sz) { - char path[PATH_MAX], socketpath[PATH_MAX]; + char *path = NULL, *socketpath = NULL; DIR *socketdir; unsigned long num_pages = 0; const char *nr_hp_file = "free_hugepages"; - snprintf(socketpath, sizeof(socketpath), "%s/node%u/hugepages", - sys_pages_numa_dir_path, socket); + if (asprintf(&socketpath, "%s/node%u/hugepages", sys_pages_numa_dir_path, socket) < 0) { + EAL_LOG(ERR, "Can not format node huge page path"); + goto nopages; + } socketdir = opendir(socketpath); if (socketdir) { @@ -149,13 +154,16 @@ get_num_hugepages_on_node(const char *subdir, unsigned int socket, size_t sz) closedir(socketdir); } else { /* Can't find socket dir, so ignore it */ - return 0; + goto nopages; + } + + if (asprintf(&path, "%s/%s/%s", socketpath, subdir, nr_hp_file) < 0) { + EAL_LOG(ERR, "Can not format free hugepages path"); + goto nopages; } - snprintf(path, sizeof(path), "%s/%s/%s", - socketpath, subdir, nr_hp_file); if (eal_parse_sysfs_value(path, &num_pages) < 0) - return 0; + goto nopages; if (num_pages == 0) EAL_LOG(WARNING, "No free %zu kB hugepages reported on node %u", @@ -168,6 +176,10 @@ get_num_hugepages_on_node(const char *subdir, unsigned int socket, size_t sz) if (num_pages > UINT32_MAX) num_pages = UINT32_MAX; +nopages: + free(path); + free(socketpath); + return num_pages; } diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c index 1e60e21620..d9e8ea76b9 100644 --- a/lib/eal/linux/eal_memalloc.c +++ b/lib/eal/linux/eal_memalloc.c @@ -260,6 +260,7 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, { int fd; int *out_fd; + const char *huge_path; struct stat st; int ret; const struct internal_config *internal_conf = @@ -276,12 +277,18 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, if (internal_conf->single_file_segments) { out_fd = &fd_list[list_idx].memseg_list_fd; - eal_get_hugefile_path(path, buflen, hi->hugedir, list_idx); + huge_path = eal_get_hugefile_path(path, buflen, hi->hugedir, list_idx); } else { out_fd = &fd_list[list_idx].fds[seg_idx]; - eal_get_hugefile_path(path, buflen, hi->hugedir, + huge_path = eal_get_hugefile_path(path, buflen, hi->hugedir, list_idx * RTE_MAX_MEMSEG_PER_LIST + seg_idx); } + if (huge_path == NULL) { + EAL_LOG(DEBUG, "%s(): hugefile path truncated: '%s'", + __func__, path); + return -1; + } + fd = *out_fd; if (fd >= 0) return fd; diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 8e1763e890..2a0a441398 100644 --- a/lib/eal/linux/eal_memory.c +++ b/lib/eal/linux/eal_memory.c @@ -337,8 +337,13 @@ map_all_hugepages(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi, hf->file_id = i; hf->size = hugepage_sz; - eal_get_hugefile_path(hf->filepath, sizeof(hf->filepath), - hpi->hugedir, hf->file_id); + if (eal_get_hugefile_path(hf->filepath, sizeof(hf->filepath), + hpi->hugedir, hf->file_id) == NULL) { + EAL_LOG(DEBUG, "%s(): huge file path '%s' truncated", + __func__, hf->filepath); + goto out; + } + hf->filepath[sizeof(hf->filepath) - 1] = '\0'; /* try to create hugepage file */ -- 2.51.0