From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300A1E6BF30 for ; Fri, 30 Jan 2026 17:43:17 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADE024067C; Fri, 30 Jan 2026 18:43:06 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mails.dpdk.org (Postfix) with ESMTP id 176254025F for ; Fri, 30 Jan 2026 18:43:01 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4806bf03573so13088395e9.2 for ; Fri, 30 Jan 2026 09:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1769794981; x=1770399781; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=79UJnlcq7hKI3GPfGnmJujQs9dghnw0mBN1qViGrAx8=; b=0P+5cqhxSoP5VW6+qaIetFl8IZyeCSWVfF22S7qYAUzEgn9GUMCCqi+oiC1n4E6vR0 3/v/PyYH39zhQz1qwuOsCotqIhk+OFivo1LgRs63Vplzpxb3hmIwwli0X32iJYStPkyb 5RxkQcSAgGzIZ8ICWT+W+HIOg5QapBqgonQJq5WVABNMKdzLP+7aE9KnnuGiycaPcNi8 y+hZ0h3tkS+gghHIGpdTNc3Xcp5auNgoLUm3UrvgbODYaoF2qe4NpYefJNw7KvJi6qEm 5dTUdle2l5+GjbWaEyjxv+h1KbzsaqUtv+kr+e5kWt/IT/kIaAEQhBGRo0Fpjcrh/qqH S3hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769794981; x=1770399781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=79UJnlcq7hKI3GPfGnmJujQs9dghnw0mBN1qViGrAx8=; b=asEVBrcDBFlYJRAhIQW0p/9+/m5swAbn/ysr5rAyVVfobnLBbmqMtL/zKk+FxIjF58 uMn1lzkqd2gFC6cDfb1QA/px4bdKeLUh5Ic6ZW9q8GSYY7PhWnxN1MUq1ABS6KP0lael gz0MMCaigN2JSCLL/fLQewmH8eh4XPT+Zqm9i7H/y936gYtCeixxBICJN1svBCi/FsK0 g5uig7aNxaBE7Q5GLOUBcx7xWnkt/4Lz6ijoR6revjvx3qHMjoERsvZ7OtEOhde36l6q Anl6rLxh07GY4UlXbeYXZD/tLddIADTfQzycr79h0Sac8FKzBMUZ8TKbIxFcuKilLVgH s7CA== X-Gm-Message-State: AOJu0YwA8uOVbcPi1xxuqGow5uuIZXbWXoRHf65qIrp/EATPWlVMrmjN EXmsQpGGEehSxI17cndr9N1+LzB+5eJltTw3LfJ+9ScSoFVwn5c/t30uT3X/KBYAIiWAsUwBCyu 5GJy1vfo= X-Gm-Gg: AZuq6aKS8YzECA9xLVvYpo1FPqJqJeXysEE2O5+1Bvxu5vpTjb75YgN/8dLoHke78UA N+S+BfNlq/qFy59wnyODlRw0zM0arA4B+mTCtJbXU4L/NF0DS/7r8qA2w8tlxQov/sPaPWVrDD5 w7I4rVKSQee50DAsE0KLVHi1xlXL/rSKodRI163vuiox8I9Opm2ebho7uN59kF5Y57X8Sjze8wc 1K4NXpfbW8lP6jOkTgY98y7ORN08GRYys9KVea5PCCnFgZCOkRvIF0um1/Tp+4OKMoYm1Se2Inz MuykXiqTo19+pGWszxwyveFLfruiIkQIRBKCK/YZfgvHhi5kh9HpA2FH3yGJoChN4W3GLsBaK7l Z8SBa3hNEgN8IRf/Z6LwP885rb6iZQKrmMcOrCPyphFukX016KSWVG1pF9Y4qBLSuuMymYYebJL WG081Grdc8ksjhX5NtHF7KHXKR5euzfj8zHrzQUqlV3g9IEpN+0g== X-Received: by 2002:a05:600c:470c:b0:47e:e952:86c9 with SMTP id 5b1f17b1804b1-482db1ffb81mr53405545e9.0.1769794980616; Fri, 30 Jan 2026 09:43:00 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806d98c8desm182241115e9.3.2026.01.30.09.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 09:43:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v10 3/4] devtools: add compare-reviews.sh for multi-provider analysis Date: Fri, 30 Jan 2026 09:41:02 -0800 Message-ID: <20260130174250.15358-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260130174250.15358-1-stephen@networkplumber.org> References: <20260109014106.398156-1-stephen@networkplumber.org> <20260130174250.15358-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add script to run patch reviews across multiple AI providers for comparison purposes. The script automatically detects which providers have API keys configured and runs analyze-patch.py for each one. This allows users to compare review quality and feedback across different AI models. Features: - Auto-detects available providers based on environment variables - Optional provider selection via -p/--providers option - Saves individual reviews to separate files with -o/--output - Verbose mode passes through to underlying analyze-patch.py Usage: ./devtools/compare-reviews.sh my-patch.patch ./devtools/compare-reviews.sh -p anthropic,xai my-patch.patch ./devtools/compare-reviews.sh -o ./reviews my-patch.patch Output files are named -.txt when using the output directory option. Signed-off-by: Stephen Hemminger --- devtools/compare-reviews.sh | 192 ++++++++++++++++++++++++++++++++++++ 1 file changed, 192 insertions(+) create mode 100644 devtools/compare-reviews.sh diff --git a/devtools/compare-reviews.sh b/devtools/compare-reviews.sh new file mode 100644 index 0000000000..a63eeffb71 --- /dev/null +++ b/devtools/compare-reviews.sh @@ -0,0 +1,192 @@ +#!/bin/bash +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2026 Stephen Hemminger + +# Compare DPDK patch reviews across multiple AI providers +# Runs analyze-patch.py with each available provider + +set -e + +SCRIPT_DIR="$(dirname "$(readlink -f "$0")")" +ANALYZE_SCRIPT="${SCRIPT_DIR}/analyze-patch.py" +AGENTS_FILE="AGENTS.md" +OUTPUT_DIR="" +PROVIDERS="" +FORMAT="text" + +usage() { + cat < + +Compare DPDK patch reviews across multiple AI providers. + +Options: + -a, --agents FILE Path to AGENTS.md file (default: AGENTS.md) + -o, --output DIR Save individual reviews to directory + -p, --providers LIST Comma-separated list of providers to use + (default: all providers with API keys set) + -f, --format FORMAT Output format: text, markdown, html, json + (default: text) + -v, --verbose Show verbose output from each provider + -h, --help Show this help message + +Environment Variables: + Set API keys for providers you want to use: + ANTHROPIC_API_KEY, OPENAI_API_KEY, XAI_API_KEY, GOOGLE_API_KEY + +Examples: + $(basename "$0") my-patch.patch + $(basename "$0") -p anthropic,openai my-patch.patch + $(basename "$0") -o ./reviews -f markdown my-patch.patch +EOF + exit "${1:-0}" +} + +error() { + echo "Error: $1" >&2 + exit 1 +} + +# Check which providers have API keys configured +get_available_providers() { + local available="" + + [[ -n "$ANTHROPIC_API_KEY" ]] && available="${available}anthropic," + [[ -n "$OPENAI_API_KEY" ]] && available="${available}openai," + [[ -n "$XAI_API_KEY" ]] && available="${available}xai," + [[ -n "$GOOGLE_API_KEY" ]] && available="${available}google," + + # Remove trailing comma + echo "${available%,}" +} + +# Get file extension for format +get_extension() { + case "$1" in + text) echo "txt" ;; + markdown) echo "md" ;; + html) echo "html" ;; + json) echo "json" ;; + *) echo "txt" ;; + esac +} + +# Parse command line options +VERBOSE="" + +while [[ $# -gt 0 ]]; do + case "$1" in + -a|--agents) + AGENTS_FILE="$2" + shift 2 + ;; + -o|--output) + OUTPUT_DIR="$2" + shift 2 + ;; + -p|--providers) + PROVIDERS="$2" + shift 2 + ;; + -f|--format) + FORMAT="$2" + shift 2 + ;; + -v|--verbose) + VERBOSE="-v" + shift + ;; + -h|--help) + usage 0 + ;; + -*) + error "Unknown option: $1" + ;; + *) + break + ;; + esac +done + +# Check for required arguments +if [[ $# -lt 1 ]]; then + echo "Error: No patch file specified" >&2 + usage 1 +fi + +PATCH_FILE="$1" + +if [[ ! -f "$PATCH_FILE" ]]; then + error "Patch file not found: $PATCH_FILE" +fi + +if [[ ! -f "$ANALYZE_SCRIPT" ]]; then + error "analyze-patch.py not found: $ANALYZE_SCRIPT" +fi + +# Validate format +case "$FORMAT" in + text|markdown|html|json) ;; + *) error "Invalid format: $FORMAT (must be text, markdown, html, or json)" ;; +esac + +# Get providers to use +if [[ -z "$PROVIDERS" ]]; then + PROVIDERS=$(get_available_providers) +fi + +if [[ -z "$PROVIDERS" ]]; then + error "No API keys configured. Set at least one of: "\ +"ANTHROPIC_API_KEY, OPENAI_API_KEY, XAI_API_KEY, GOOGLE_API_KEY" +fi + +# Create output directory if specified +if [[ -n "$OUTPUT_DIR" ]]; then + mkdir -p "$OUTPUT_DIR" +fi + +PATCH_BASENAME=$(basename "$PATCH_FILE") +PATCH_STEM="${PATCH_BASENAME%.*}" +EXT=$(get_extension "$FORMAT") + +echo "Reviewing patch: $PATCH_BASENAME" +echo "Providers: $PROVIDERS" +echo "Format: $FORMAT" +echo "========================================" +echo "" + +# Run review for each provider +IFS=',' read -ra PROVIDER_LIST <<< "$PROVIDERS" +for provider in "${PROVIDER_LIST[@]}"; do + echo ">>> Running review with: $provider" + echo "" + + if [[ -n "$OUTPUT_DIR" ]]; then + OUTPUT_FILE="${OUTPUT_DIR}/${PATCH_STEM}-${provider}.${EXT}" + python3 "$ANALYZE_SCRIPT" \ + -p "$provider" \ + -a "$AGENTS_FILE" \ + -f "$FORMAT" \ + $VERBOSE \ + "$PATCH_FILE" | tee "$OUTPUT_FILE" + echo "" + echo "Saved to: $OUTPUT_FILE" + else + python3 "$ANALYZE_SCRIPT" \ + -p "$provider" \ + -a "$AGENTS_FILE" \ + -f "$FORMAT" \ + $VERBOSE \ + "$PATCH_FILE" + fi + + echo "" + echo "========================================" + echo "" +done + +echo "Review comparison complete." + +if [[ -n "$OUTPUT_DIR" ]]; then + echo "All reviews saved to: $OUTPUT_DIR" +fi -- 2.51.0