From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16FDE7C6E2 for ; Sat, 31 Jan 2026 20:02:04 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92E6A402AF; Sat, 31 Jan 2026 21:02:03 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 85AC040274 for ; Sat, 31 Jan 2026 21:02:01 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-432d2c7dd52so3070107f8f.2 for ; Sat, 31 Jan 2026 12:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1769889721; x=1770494521; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=l8/k/m/LCiokIwPUihnLxqGB10j5ieWZcNq0Fy1ja4E=; b=kS3rlRgGjYQ/quuJwXsGWLfB31nIhK5gtNnRsttWO53ZhEADijzn7suZ2WffK+SS7q D6zCjSvcwKRHl+Cbvh5bcuH7uikAEkLfWlvmwRyMX+otHHxfp2S+GAdLPYcb7wtAOyK5 WaiA5mVVCS1LxMNzWOI5jdxjHBLvask+/URRjXYvbl9IHxJMsZCEsYeRmuoQ8mK3sJsX i/HH10jBJwDzGUi4RwTmTnLHZWAPQ9A0OAla3dcYmK/G4IoPKEZqHLF8XfxkB83B0FNs W+pekRn2Jn91VCBhZo6q+G8mbNU+jCxOwNg8WmdCO5gd9mDDifLMa8Ku7z/Ywu7fJ1ho ckDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769889721; x=1770494521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=l8/k/m/LCiokIwPUihnLxqGB10j5ieWZcNq0Fy1ja4E=; b=h59bqm0z6INgSu/BH8CGqpGktEhcxmPWF1bnY3BZCsAn1D+3NkwAoUKdbxrfeYr2W3 yFM62iLB3icnvztmE6eaRQ24VGbreuNTSs04jRCBxBwcqB4ObV0h4mTJk/JDks6Ebbgi EWhMQcBhZCvN50GXm9mDj4uSrWSXcBtADVsMhSkjTgUyOtnlFG7e0uGaYoD/1BELr1hM Sc6QgMj03UGT1YbPTR6Rh2bHCaOGyKNSxNN82qQEK4wdaF187sc0Bo/7W+oysKAilLiQ 7miePAnS4A4X+kqDZOibnyJtU/kXon2brmiJn2PmITKmRGxy2/J93ybd1ly1aTDhz9kA igyw== X-Gm-Message-State: AOJu0YwydH0JFgffwprF3Na+PRSFGuvhTjvUsdzTZQ0wtWrEqDyLbm7Y bSaeQF/yg7MMbwDVwfdOz7Ip/w7H9QWl3zrMLohBxwjUZ0NmZON5NGK06q+H1oocLfw= X-Gm-Gg: AZuq6aKhpGQ2JQFCXmMuSVT1ERyg6hxj0MDi1JEHONFT8M+twoM+Xs+Dj81uNPpjJWZ 4PvxJqMDr8G61dkBLyUpMTOmJDpVr+58WX/CraTZzDfGvnnzeICcIpSm1oW0+5lWR75YnVv4m9W Ikvyxl4YLY3Laqax+NoiXWuJc8W7xPMvk3PuuL9QN2mln/Va0MHCGjIqScHfuCyrPxmPkhfB5XD GR1Fmeca3j2ZjrTtmz+8gYkKdzR53NCp0HViOc3Kl8T9CKKtCT2oAk2ajRfII2vnjGHnNab8QH7 ARLjG28hFiAfC0j7BVey8ylQ+FCxRPl27pzsVpEXuZb2Vgtz2RuZTfSA44x6Xsdz5HOoBjBd/IU TafmdD7+NvedA/iU2+H+rUGkMCcA6G1AE/yA2v2LVd+5iHLK2D40RK1RinUB9keOysJd7b7p/lN rDnrmdm6JR3hK+kMcZOSOFvqFb7ralTtBtqRZsPcBnU5i73ssMBrx0 X-Received: by 2002:a05:6000:2001:b0:435:97ab:1299 with SMTP id ffacd0b85a97d-435f3abc8f3mr10017002f8f.51.1769889720657; Sat, 31 Jan 2026 12:02:00 -0800 (PST) Received: from phoenix.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e132368csm29395522f8f.31.2026.01.31.12.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 12:02:00 -0800 (PST) Date: Sat, 31 Jan 2026 12:01:55 -0800 From: Stephen Hemminger To: Sebastian Brzezinka Cc: dev@dpdk.org, Alexey Marchuk Subject: Re: [PATCH 1/2] meson/mlx5: Suppress -Wunused-value diagnostic Message-ID: <20260131120155.3b54c289@phoenix.local> In-Reply-To: <20240412111317.3530529-1-sebastian.brzezinka@intel.com> References: <20240412111317.3530529-1-sebastian.brzezinka@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 12 Apr 2024 13:13:16 +0200 Sebastian Brzezinka wrote: > From: Alexey Marchuk > > mlx5 common library checks if several symbols/definitions > are presented in system header files. If some are not > presented, they will be enabled by mlx5_glue library. > The problem appears with clang and '-Werror' - code > generated by meson is not compiled due to unused variable: > > Code: > > #include > int main(void) { > /* If it's not defined as a macro, try to use as a symbol */ > #ifndef mlx5dv_create_flow_action_packet_reformat > mlx5dv_create_flow_action_packet_reformat; > #endif > return 0; > } > Compiler stdout: > > Compiler stderr: > /hpc/local/work/alexeymar/repo/spdk/dpdk/build-tmp/meson-private/tmp5obnak86/testfile.c:6:17: error: expression result unused [-Werror,-Wunused-value] > mlx5dv_create_flow_action_packet_reformat; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > As result, almost all symbols are enabled in mlx5_glue while > they exist is system headers. As result, we get multiple > symbols redefenitions when we compile mlx5_common. > As a solution for this problem we can suppress > -Wunused-vaurable using pragma > > DPDK 23.11 note: > Starting with commit below, all cflags are passed to the has_header_symbol(). > (33d6694) build: use C11 standard > To make sure that the symbol is properly detected, the pedantic flags needs to > be removed. > > Signed-off-by: Alexey Marchuk > Signed-off-by: Sebastian Brzezinka > --- > drivers/common/mlx5/linux/meson.build | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build > index cdee40c553..f3b8e5741b 100644 > --- a/drivers/common/mlx5/linux/meson.build > +++ b/drivers/common/mlx5/linux/meson.build > @@ -209,7 +209,11 @@ if libmtcr_ul_found > endif > > foreach arg:has_sym_args > - mlx5_config.set(arg[0], cc.has_header_symbol(arg[1], arg[2], dependencies: libs, args: cflags)) > + file_prefix = '#pragma clang diagnostic ignored "-Wunused-value"' > + cflags += [ > + '-Wno-pedantic', > + ] > + mlx5_config.set(arg[0], cc.has_header_symbol(arg[1], arg[2], prefix : file_prefix, dependencies: libs, args: cflags)) > endforeach > foreach arg:has_member_args > file_prefix = '#include <' + arg[1] + '>' NAK This adds more complexity to already overly complex meson build for mlx5.