Re: [REVIEW] doc/nfb: cleanup and update guide

Stephen Hemminger
2026-02-02T17:54:57Z

On Mon, 2 Feb 2026 09:42:35 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> ## Summary
>
> ### Errors (Must Fix)
> 1. **Patch 2**: `__rte_internal` function declarations should have return type on separate line per DPDK style.
>
> ### Warnings (Should Fix)
> 1. **Patch 1**: Line exceeds 100 characters in nfb_ethdev.c.
> 2. **Patch 2**: Extra blank line in nfb.h; line exceeds 100 characters.
> 3. **Patches 3, 4**: Unnecessary `(void *)` cast.
> 4. **Patch 3**: Verify file ends with newline.
>
> ### General Observations
> - The patch series is well-structured with clear separation of concerns.
> - Commit messages are well-written and follow DPDK conventions.
> - The code changes are logical and the multi-port architecture is cleanly implemented.
> - Documentation is updated appropriately with release notes.

I am fine with patch as is. But getting merge conflicts with next-net and main.
Please rebse.