Re: [PATCH v2 0/8] net/nfb: rework to real multiport

Stephen Hemminger
2026-01-20T02:25:55Z

On Fri, 16 Jan 2026 17:44:28 +0100
spinler@cesnet.cz wrote:

> From: Martin Spinler <spinler@cesnet.cz>
>
> This series implements real multiport for better user experience.
>
> The existing driver creates one ethdev/port for one PCI device.
> As the CESNET-NDK based cards aren't capable to represent each
> Ethernet port by own PCI device, new driver implementation
> processes real port configuration from firmware/card and switches
> from rte_eth_dev_pci_generic_probe to multiple rte_eth_dev_create calls.

You still are using int for queue_max_rx and tx which seems wrong.
In general, this driver code seems to use int like old C code from K&R era.
Avoid using strtol() if you only want unsigned values.

Don't use RTE_ASSERT() for error checking, it gets compiled out usually.
Instead check for snprintf overflows and return EINVAL or ENAMETOOLONG error.

Some comments from AI reviewers.

Series-wide - ⚠️ Missing release notes for significant changes:
Multi-port architecture change
New vdev support
Port selection feature
New hardware support (3 card types)

More comments from AI but I don't trust these.
For example, it thinks DYNANIC is misspelling of DYNAMIC

Errors (Must Fix)

Patch 2/8: __rte_internal not alone on its own line (nfb.h lines 343, 348)

Warnings (Should Fix)

Patch 1/8: Grammar typo "doesn't necessary corresponds" (appears in both nfb_rx.c and nfb_tx.c)
Patch 3/8: Missing trailing newline at end of nfb_vdev.c
Patch 5/8: Return values of nfb_nc_rxmac_init() / nfb_nc_txmac_init() not checked
Patch 8/8: Typos "DYNANIC" and "found int the"

Info (Consider)

Magic number 64 could be a named constant
Minor Doxygen comment formatting