From: Stephen Hemminger <stephen@networkplumber.org>
To: Lukas Sismis <sismis@dyna-nic.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v10 3/6] flow_parser: add shared parser library
Date: Mon, 2 Feb 2026 12:03:13 -0800 [thread overview]
Message-ID: <20260202120313.15ecedb3@phoenix.local> (raw)
In-Reply-To: <20260202113659.24052-4-sismis@dyna-nic.com>
On Mon, 2 Feb 2026 12:36:55 +0100
Lukas Sismis <sismis@dyna-nic.com> wrote:
> +int
> +rte_flow_parser_run(const char *src)
> +{
> + uint8_t buf[4096];
> + struct rte_flow_parser_output *out = (struct rte_flow_parser_output *)buf;
> + int ret;
> +
> + ret = rte_flow_parser_parse(src,
> + (struct rte_flow_parser_output *)buf,
> + sizeof(buf));
> + if (ret < 0)
> + return ret;
> + switch (out->command) {
> + case RTE_FLOW_PARSER_CMD_SET_SAMPLE_ACTIONS:
> + case RTE_FLOW_PARSER_CMD_SET_IPV6_EXT_PUSH:
> + case RTE_FLOW_PARSER_CMD_SET_IPV6_EXT_REMOVE:
> + case RTE_FLOW_PARSER_CMD_SET_RAW_ENCAP:
> + case RTE_FLOW_PARSER_CMD_SET_RAW_DECAP:
> + cmd_set_raw_parsed(out);
> + break;
> + default:
> + return cmd_flow_parsed(out);
> + break;
The kernel version of checkpatch complains here. The DPDK shell script
seems to be set to ignore this but.
WARNING: break is not useful after a return
#15008: FILE: lib/flow_parser/rte_flow_parser.c:14763:
+ return cmd_flow_parsed(out);
+ break;
next prev parent reply other threads:[~2026-02-02 20:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 11:36 [PATCH v10 0/6] flow_parser: add shared parser library Lukas Sismis
2026-02-02 11:36 ` [PATCH v10 1/6] cmdline: include stddef.h for MSVC compatibility Lukas Sismis
2026-02-02 11:36 ` [PATCH v10 2/6] ethdev: add RSS type helper APIs Lukas Sismis
2026-02-17 14:40 ` Stephen Hemminger
2026-02-02 11:36 ` [PATCH v10 4/6] app/testpmd: use shared flow parser library Lukas Sismis
2026-02-02 11:36 ` [PATCH v10 5/6] examples/flow_parsing: add flow parser demo Lukas Sismis
2026-02-02 11:36 ` [PATCH v10 6/6] test: add flow parser library functional tests Lukas Sismis
2026-02-02 18:37 ` [PATCH v10 0/6] flow_parser: add shared parser library Stephen Hemminger
[not found] ` <20260202113659.24052-4-sismis@dyna-nic.com>
2026-02-02 20:03 ` Stephen Hemminger [this message]
2026-02-03 8:34 ` [PATCH v10 3/6] " Lukáš Šišmiš
2026-02-04 14:53 ` Stephen Hemminger
2026-02-06 14:01 ` Thomas Monjalon
2026-02-06 15:40 ` Lukáš Šišmiš
2026-02-13 0:43 ` Stephen Hemminger
2026-02-13 7:46 ` Lukáš Šišmiš
2026-02-13 19:16 ` Stephen Hemminger
2026-02-14 4:35 ` Stephen Hemminger
2026-02-10 14:44 ` Stephen Hemminger
2026-02-10 14:45 ` [PATCH v10 0/6] " Stephen Hemminger
2026-02-12 8:56 ` Lukáš Šišmiš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202120313.15ecedb3@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=sismis@dyna-nic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox