From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
stable@dpdk.org, Tetsuya Mukawa <mtetsuyah@gmail.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: [PATCH v11 2/7] net/null: cleanup info response
Date: Mon, 2 Feb 2026 14:16:47 -0800 [thread overview]
Message-ID: <20260202221820.204680-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20260202221820.204680-1-stephen@networkplumber.org>
The info_get callback doesn't need to check its args
since already done by ethdev.
The null driver generates fake packets of configured packet_size.
The mbuf pool passed when setting up Rx queue must have space
to hold the requested packet size; otherwise eth_null_copy_rx()
would generate invalid mbufs.
Setting min_rx_bufsize to packet_size enables the existing
validation in rte_eth_rx_queue_setup() to reject undersized pools.
Fixes: c743e50c475f ("null: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/null/rte_eth_null.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 0931dac12e..f2ffdc2b2b 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -299,17 +299,13 @@ static int
eth_dev_info(struct rte_eth_dev *dev,
struct rte_eth_dev_info *dev_info)
{
- struct pmd_internals *internals;
-
- if ((dev == NULL) || (dev_info == NULL))
- return -EINVAL;
+ struct pmd_internals *internals = dev->data->dev_private;
- internals = dev->data->dev_private;
dev_info->max_mac_addrs = 1;
- dev_info->max_rx_pktlen = (uint32_t)-1;
+ dev_info->max_rx_pktlen = UINT32_MAX;
dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);
dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues);
- dev_info->min_rx_bufsize = 0;
+ dev_info->min_rx_bufsize = internals->packet_size;
dev_info->tx_offload_capa = RTE_ETH_TX_OFFLOAD_MULTI_SEGS | RTE_ETH_TX_OFFLOAD_MT_LOCKFREE;
dev_info->reta_size = internals->reta_size;
--
2.51.0
next prev parent reply other threads:[~2026-02-02 22:18 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 22:25 [PATCH] test: add a test for null PMD Stephen Hemminger
2026-01-05 14:49 ` Marat Khalili
2026-01-05 17:38 ` Stephen Hemminger
2026-01-06 16:47 ` [PATCH v2 0/2] net/null: add a test Stephen Hemminger
2026-01-06 16:47 ` [PATCH v2 1/2] test: add a test for null PMD Stephen Hemminger
2026-01-06 17:40 ` Marat Khalili
2026-01-06 18:01 ` Stephen Hemminger
2026-01-06 16:47 ` [PATCH v2 2/2] net/null: revise info_get Stephen Hemminger
2026-01-08 20:40 ` [PATCH v3 0/3] test: new test for null PMD Stephen Hemminger
2026-01-08 20:40 ` [PATCH v3 1/3] net/null: cleanup info_get Stephen Hemminger
2026-01-08 20:40 ` [PATCH v3 2/3] test: allow larger packet sizes Stephen Hemminger
2026-01-09 15:00 ` Morten Brørup
2026-01-10 17:21 ` Stephen Hemminger
2026-01-08 20:40 ` [PATCH v3 3/3] test: add a test for null PMD Stephen Hemminger
2026-01-09 1:21 ` Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 0/3] null pmd minor cleanup and add test Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 1/3] net/null: cleanup info_get Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 2/3] test: generate larger packet bursts Stephen Hemminger
2026-01-10 17:22 ` [PATCH v4 3/3] test: add a test for null PMD Stephen Hemminger
2026-01-12 0:56 ` [PATCH v4 0/3] null pmd minor cleanup and add test Stephen Hemminger
2026-01-14 18:30 ` [PATCH v5 0/3] test: add null PMD test suite Stephen Hemminger
2026-01-14 18:30 ` [PATCH v5 1/3] net/null: cleanup info_get Stephen Hemminger
2026-01-14 18:30 ` [PATCH v5 2/3] test: generate larger packet bursts Stephen Hemminger
2026-01-14 18:30 ` [PATCH v5 3/3] test: add a test for null PMD Stephen Hemminger
2026-01-18 16:50 ` [PATCH v6 0/3] test: add null PMD test suite Stephen Hemminger
2026-01-18 16:50 ` [PATCH v6 1/3] net/null: cleanup info response Stephen Hemminger
2026-01-18 16:50 ` [PATCH v6 2/3] test: generate larger packet bursts Stephen Hemminger
2026-01-18 16:50 ` [PATCH v6 3/3] test: add a test for null PMD Stephen Hemminger
2026-01-25 20:23 ` [PATCH v7 0/5] net/null: improvements and bug fixes Stephen Hemminger
2026-01-25 20:23 ` [PATCH v7 1/5] net/null: cleanup info response Stephen Hemminger
2026-01-25 20:23 ` [PATCH v7 2/5] test: generate larger packet bursts Stephen Hemminger
2026-01-25 20:23 ` [PATCH v7 3/5] test: add a test for null PMD Stephen Hemminger
2026-01-25 20:23 ` [PATCH v7 4/5] net/null: add check for pool vs packet size Stephen Hemminger
2026-01-25 20:23 ` [PATCH v7 5/5] net/null: check packet size argument Stephen Hemminger
2026-01-28 19:00 ` [PATCH v8 0/5] net/null: improvements and bug fixes Stephen Hemminger
2026-01-28 19:00 ` [PATCH v8 1/5] net/null: cleanup info response Stephen Hemminger
2026-01-28 19:00 ` [PATCH v8 2/5] test: generate larger packet bursts Stephen Hemminger
2026-01-28 19:00 ` [PATCH v8 3/5] test: add a test for null PMD Stephen Hemminger
2026-01-28 19:00 ` [PATCH v8 4/5] net/null: add check for pool vs packet size Stephen Hemminger
2026-01-28 19:00 ` [PATCH v8 5/5] net/null: check packet size argument Stephen Hemminger
2026-01-29 20:25 ` [PATCH v9 0/5] net/null: improvements and bug fixes Stephen Hemminger
2026-01-29 20:25 ` [PATCH v9 1/5] net/null: cleanup info response Stephen Hemminger
2026-01-29 20:25 ` [PATCH v9 2/5] net/null: validate the numeric devargs Stephen Hemminger
2026-01-29 20:25 ` [PATCH v9 3/5] net/null: remove redundant argument validation Stephen Hemminger
2026-01-29 20:25 ` [PATCH v9 4/5] test: support larger packet sizes in burst generator Stephen Hemminger
2026-01-29 20:25 ` [PATCH v9 5/5] test: add a test for null PMD Stephen Hemminger
2026-02-01 17:17 ` [PATCH v10 0/6] net/null: bug fixes and improvements Stephen Hemminger
2026-02-01 17:17 ` [PATCH v10 1/6] net/null: fix missing mbuf leakage in the copy transmit Stephen Hemminger
2026-02-01 17:17 ` [PATCH v10 2/6] net/null: cleanup info response Stephen Hemminger
2026-02-01 17:17 ` [PATCH v10 3/6] net/null: validate the numeric devargs Stephen Hemminger
2026-02-01 17:17 ` [PATCH v10 4/6] net/null: remove redundant argument validation Stephen Hemminger
2026-02-01 17:17 ` [PATCH v10 5/6] test: support larger packet sizes in burst generator Stephen Hemminger
2026-02-01 17:17 ` [PATCH v10 6/6] test: add a test for null PMD Stephen Hemminger
2026-02-02 22:16 ` [PATCH v11 0/7] net/null: bug fixes and improvements Stephen Hemminger
2026-02-02 22:16 ` [PATCH v11 1/7] net/null: fix missing mbuf leakage in the copy transmit Stephen Hemminger
2026-02-02 22:16 ` Stephen Hemminger [this message]
2026-02-02 22:16 ` [PATCH v11 3/7] net/null: validate the numeric devargs Stephen Hemminger
2026-02-02 22:16 ` [PATCH v11 4/7] net/null: remove redundant argument validation Stephen Hemminger
2026-02-02 22:16 ` [PATCH v11 5/7] test: support larger packet sizes in burst generator Stephen Hemminger
2026-02-02 22:16 ` [PATCH v11 6/7] test: add a test for null PMD Stephen Hemminger
2026-02-02 22:16 ` [PATCH v11 7/7] net/null: add VLAN insert and strip offload support Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202221820.204680-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox