Re: [v3,0/5] net/zxdh: add support some new features

[Junlong Wang <wang.junlong1@zte.com.cn>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1785 bytes --]

> >  drivers/net/zxdh/zxdh_pci.h            |   2 +
> >  drivers/net/zxdh/zxdh_queue.c          | 137 +++++++++++---
> >  drivers/net/zxdh/zxdh_queue.h          |  12 +-
> >  drivers/net/zxdh/zxdh_rxtx.c           | 117 +++++++++---
> >  drivers/net/zxdh/zxdh_tables.h         |  12 +-
> >  14 files changed, 655 insertions(+), 227 deletions(-)
> > 

> This looks much better, there a couple of AI review complaints about
> commit message style. I will address those during the merge.

> For example, the AI generated commit message for the second patch
> would be:

> net/zxdh: optimize queue resource allocation with hardware locking

> This patch refactors the queue resource allocation mechanism to improve
> performance and reduce complexity by moving the allocation operation
> inside the hardware lock critical section.

> Key changes:
> - Remove the complex zxdh_common_table_write() function and its
>   associated messaging infrastructure
> - Simplify zxdh_datach_set() to directly write PCIe ID to hardware
>   registers using BAR0 memory mapping
> - Move queue resource allocation (zxdh_datach_set) inside the hardware
>   lock critical section in zxdh_get_available_channel()
> - Remove the separate zxdh_datach_set() call from zxdh_reconfig_queues()
>   since it's now handled during channel allocation
> - Add new PCIe ID address and size definitions for direct register access

> This optimization eliminates the overhead of complex message passing for
> queue setup operations while ensuring atomic allocation of queue resources
> under hardware lock protection.

This looks good for me and matches expectations.
Sorry for causing you extra work.

When submitting new patches in next, I will provide clearer patch commit messages.

[-- Attachment #1.1.2: Type: text/html , Size: 3499 bytes --]