Re: [PATCH] license: standardize SPDX tag for 3-Clause BSD

Stephen Hemminger
2026-01-14T06:00:31Z

On Wed, 12 Nov 2025 10:43:16 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 12/11/2025 10:41, Bruce Richardson:
> > On Wed, Nov 12, 2025 at 10:38:44AM +0100, Thomas Monjalon wrote:
> > > 12/11/2025 10:31, Bruce Richardson:
> > > > On Wed, Nov 12, 2025 at 10:13:35AM +0100, Thomas Monjalon wrote:
> > > > > Make sure the SPDX tag is used as defined in license/README.
> > > > > Reduce separator to single space.
> > > > > Use parenthesis and uppercased "OR" when a second license is applied.
> > > >
> > > > Upper-case or is fine, I suppose, but I'm not convinced we need the
> > > > parentheses. However, I see other drivers tend to have it, so let's
> > > > standardize on that.
> > >
> > > I'm not convinced as well.
> > >
> > > Looking at https://spdx.dev/learn/handling-license-info/
> > > it seems we don't need parentheses in general.
> > >
> > Shall we just avoid fixing the parens until we definitively decide on that.
> > Just standardize on spacing and upper case "OR"? Whatever approach you
> > decide for this release, you can keep my ack.
>
> I plan to rework this patch by standardizing without parentheses,
> and add more checks.

Ping.
Yes paren's look wrong.