public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: malikovyehor@gmail.com
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, chenbox@nvidia.com,
	Yehor Malikov <Yehor.Malikov@solidigm.com>
Subject: Re: [PATCH v2] vhost: fix use-after-free in fdset during shutdown
Date: Thu, 5 Feb 2026 08:46:24 -0800	[thread overview]
Message-ID: <20260205084624.1a733c7a@phoenix.local> (raw)
In-Reply-To: <20260204184011.8722-1-Yehor.Malikov@solidigm.com>

On Wed,  4 Feb 2026 19:40:11 +0100
malikovyehor@gmail.com wrote:

> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index 9b4f332f94..e953dd1849 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -1209,3 +1209,11 @@ rte_vhost_driver_start(const char *path)
>  	else
>  		return vhost_user_start_client(vsocket);
>  }
> +
> +RTE_FINI(vhost_user_fdset_fini)
> +{
> +	if (vhost_user.fdset != NULL) {
> +		fdset_deinit(vhost_user.fdset);
> +		vhost_user.fdset = NULL;
> +	}
> +}

NAK
This should be done as via rte_eal_cleanup.
Did you not see previous analysis?

  reply	other threads:[~2026-02-05 16:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 18:40 [PATCH v2] vhost: fix use-after-free in fdset during shutdown malikovyehor
2026-02-05 16:46 ` Stephen Hemminger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-04 18:42 malikovyehor
2026-02-04 18:03 [PATCH] " Yehor Malikov
2026-02-04 18:48 ` [PATCH v2] " malikovyehor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260205084624.1a733c7a@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=Yehor.Malikov@solidigm.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=malikovyehor@gmail.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox