Re: [PATCH v5 03/14] net/sxe: add tx rx setup and data path

Stephen Hemminger
2025-07-17T18:05:32Z

On Wed, 9 Jul 2025 21:20:10 -0400
Jie Liu <liujie5@linkdatatechnology.com> wrote:

> +s32 __rte_cold __sxe_rx_queue_setup(struct rx_setup *rx_setup, bool is_vf)
> +{

Please don't use __rte_cold in driver.
It really is only needed in the core code (for example rte_log)
as a way to tell compiler: "If the code path calls this function it
can not possibly be critical performance".

Putting it in driver is just clutter.