Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

Stephen Hemminger
2025-07-16T20:40:13Z

On Wed, 16 Jul 2025 04:29:18 -0400
Jie Liu <liujie5@linkdatatechnology.com> wrote:

> diff --git a/drivers/net/sxe/meson.build b/drivers/net/sxe/meson.build
> index dad9ee44a0..34571522f7 100644
> --- a/drivers/net/sxe/meson.build
> +++ b/drivers/net/sxe/meson.build
> @@ -1,9 +1,22 @@
> # SPDX-License-Identifier: BSD-3-Clause
> -# Copyright (C), 2020, Wuxi Stars Micro System Technologies Co., Ltd.
> +# Copyright (C), 2022, Linkdata Technology Co., Ltd.

I assume you got acquired, changing Copyright requires approval of
the original author.

> +cflags += ['-DSXE_DPDK']
> +cflags += ['-DSXE_HOST_DRIVER']

Please avoid #ifdef and cflags. The problem is that no one ever
tests the negative case. As Yoda said:
"Do or do not, there is no try"

> +
> +#subdir('base')
> +#objs = [base_objs]