From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: [PATCH] net/mlx5: fix flow mark reading after reconfigure
Date: Wed, 11 Feb 2026 09:12:38 +0100 [thread overview]
Message-ID: <20260211081239.191118-1-dsosnowski@nvidia.com> (raw)
mlx5 PMD supports flow mark action which attaches additional
metadata to received packets. This metadata is stored
in the rte_mbuf in hash.fdir.hi field and applications
are notified about it with RTE_MBUF_F_RX_FDIR mbuf flag.
When working with HW Steering flow engine,
mlx5 PMD reads the HW completion entry field with flow mark value
if and only if at least one template table with flow mark action
was created.
Whenever table was created mlx5 PMD updated the private
data of each Rx queue to inform
Rx burst function to read HW field.
Whenever application reconfigures any of the Rx queues
through additional call to rte_eth_rx_queue_setup(),
this private Rx queue data is reset, but information
about existence of flow mark was not restored by PMD.
As a result, reconfiguration caused applications
to not receive flow mark metadata.
This patch fixes that behavior. Whenever port is started,
PMD will check if flow mark action is used and update
relevant private Rx queue data struct.
Fixes: 1deadfd709f5 ("net/mlx5: add HW mark action")
Cc: stable@dpdk.org
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Acked-by: Bing Zhao <bingz@nvidia.com>
---
drivers/net/mlx5/mlx5_flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 0821c93a9a..5add0c4a2b 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1898,6 +1898,7 @@ mlx5_flow_rxq_dynf_set(struct rte_eth_dev *dev)
data->flow_meta_port_mask = priv->sh->dv_meta_mask;
}
}
+ data->mark = !!priv->mark_enabled;
data->mark_flag = mark_flag;
}
}
--
2.47.3
next reply other threads:[~2026-02-11 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 8:12 Dariusz Sosnowski [this message]
2026-02-24 11:40 ` [PATCH] net/mlx5: fix flow mark reading after reconfigure Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211081239.191118-1-dsosnowski@nvidia.com \
--to=dsosnowski@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox